Skip to content

Commit

Permalink
Add nodejs 22.x as latest LTS (#999)
Browse files Browse the repository at this point in the history
This patch:

1. Remove 18.x from actions.
2. Add latest 22.x into actions.

Fix: #998
  • Loading branch information
minggangw authored Nov 4, 2024
1 parent 1db8ad6 commit d57c316
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linux-build-and-test-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.X, 20.X]
node-version: [20.X, 22.X]
ros_distribution:
- jazzy
- iron
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux-build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.X, 20.X]
node-version: [20.X, 22.X]
steps:
- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-build-and-test-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.16.0, 20.X]
node-version: [22.X]
ros_distribution:
- jazzy
- iron
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/windows-build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# Explicit node versions are used to workaround an error
# where node-gyp fails due to some silly cacheing
node-version: [18.16.0, 20.X]
node-version: [22.X]
steps:
- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/[email protected]
Expand Down

0 comments on commit d57c316

Please sign in to comment.