Fix #74, memory leak in verifyBlock()

RobTillaart · Oct 9, 2024 · f556308 · f556308
1 parent 0de303f
commit f556308
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,10 +6,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
 
+## [1.9.0] - 2024-10-09
+- Fix #74, memory leak in setBlockVerify() - kudos to cmichailidis
+
+----
+
 ## [1.8.5] - 2024-04-22
 - Fix #72, force requestFrom parameters to use int type
 
-
 ## [1.8.4] - 2024-04-20
 - Fix #70, increase length internal buffer.
 - add compile time flag **EN_AUTO_WRITE_PROTECT** (thanks to microfoundry)

diff --git a/I2C_eeprom.cpp b/I2C_eeprom.cpp
@@ -1,7 +1,7 @@
 //
 //    FILE: I2C_eeprom.cpp
 //  AUTHOR: Rob Tillaart
-// VERSION: 1.8.5
+// VERSION: 1.9.0
 // PURPOSE: Arduino Library for external I2C EEPROM 24LC256 et al.
 //     URL: https://github.com/RobTillaart/I2C_EEPROM
 
@@ -235,7 +235,11 @@ bool I2C_eeprom::setBlockVerify(const uint16_t memoryAddress, const uint8_t valu
   if (setBlock(memoryAddress, value, length) != 0) return false;
   uint8_t * data = (uint8_t *) malloc(length);
   if (data == NULL) return false;
-  if (readBlock(memoryAddress, data, length) != length) return false;
+  if (readBlock(memoryAddress, data, length) != length)
+  {
+    free(data);
+    return false;
+  }
   for (uint16_t i = 0; i < length; i++)
   {
     if (data[i] != value)

diff --git a/I2C_eeprom.h b/I2C_eeprom.h
@@ -2,7 +2,7 @@
 //
 //    FILE: I2C_eeprom.h
 //  AUTHOR: Rob Tillaart
-// VERSION: 1.8.5
+// VERSION: 1.9.0
 // PURPOSE: Arduino Library for external I2C EEPROM 24LC256 et al.
 //     URL: https://github.com/RobTillaart/I2C_EEPROM
 
@@ -11,7 +11,7 @@
 #include "Wire.h"
 
 
-#define I2C_EEPROM_VERSION          (F("1.8.5"))
+#define I2C_EEPROM_VERSION          (F("1.9.0"))
 
 #define I2C_DEVICESIZE_24LC512      65536
 #define I2C_DEVICESIZE_24LC256      32768

diff --git a/README.md b/README.md
@@ -38,6 +38,8 @@ If a better solution is found, it will be implemented.
 
 #### Breaking change
 
+Version 1.9.0 fixed a memory leak in **verifyBlock()**.
+
 Version 1.8.0 introduced a breaking change.
 You cannot set the pins in **begin()** any more.
 This reduces the dependency of processor dependent Wire implementations.

diff --git a/library.json b/library.json
@@ -15,7 +15,7 @@
     "type": "git",
     "url": "https://github.com/RobTillaart/I2C_EEPROM.git"
   },
-  "version": "1.8.5",
+  "version": "1.9.0",
   "license": "MIT",
   "frameworks": "*",
   "platforms": "*",

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=I2C_EEPROM
-version=1.8.5
+version=1.9.0
 author=Rob Tillaart <[email protected]>
 maintainer=Rob Tillaart <[email protected]>
 sentence=Library for I2C EEPROMS