add support for endroid/qr-code version 6 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for looking at this so quickly! ^6 has been added to the list of tested package versions |
|
I suggest dropping versions 3 and 4 from our code/test. No need to try and be compatible with php 5.6 era libraries. Not necessarily in this PR, but adding support for a new version should come with dropping support for the oldest one, too. Or you end up with too many codepaths, maintenance cost, attack surface, etc... |
|
Its no skin off my back, they do still install on PHP 8 though so we'd have to add a conflicts in composer.json to reject those versions right? Probably easier to pull off next year with PHP 9 😅 |
willpower232
approved these changes
Oct 23, 2024
NicolasCARPi
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature added
Updated EndroidQrCodeProvider to work with version 6 of optional endroid/qr-code repository. (Breaking change in dependency: setter methods removed in favor of more modern practice of passing properties to QrCode constructor)
Testing
Confirmed that EndroidQRCodeTest passes with either version 5 or 6 of endroid/qr-code installed