Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.4 #497

Open
wants to merge 2 commits into
base: 1.36.x
Choose a base branch
from
Open

Support PHP 8.4 #497

wants to merge 2 commits into from

Conversation

staabm
Copy link

@staabm staabm commented May 25, 2024

No description provided.

@staabm staabm marked this pull request as ready for review May 25, 2024 12:04
@staabm staabm mentioned this pull request May 25, 2024
Open
Ocramius
Ocramius requested changes May 25, 2024
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'd only merge after a green 8.4 CI run

composer.json Show resolved Hide resolved
@staabm
Copy link
Author

staabm commented May 25, 2024 •
edited
Loading

Note: I'd only merge after a green 8.4 CI run

I ran it locally successfully against 8.4. :)
need to have a look where/how to make CI run on 8.4

@Ocramius
Copy link
Member

You'd need to check the upstream laminas CI actions 👍

@fezfez fezfez mentioned this pull request Aug 3, 2024
Merged
@vjik
Copy link

vjik commented Nov 21, 2024

How are you doing with this PR? PHP 8.4 is released, the time has come :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staabm @Ocramius @vjik