485: Include output from Psalm in report when mutatnt killed by stati… #490
Conversation
bdsl
force-pushed
the
485-include-psalm-output-in-report
branch
2 times, most recently
from
ae4c267
to
8811d56
Compare
bdsl
force-pushed
the
485-include-psalm-output-in-report
branch
from
8811d56
to
f0265a0
Compare
…le tested is temp file
| * @psalm-suppress InternalProperty - we use Psalm's internal IssueData class here. Afaik the only other way to | ||
| * display details of the issues would be to use one of the subclasses of \Psalm\Report, but I think none are exactly | ||
| * what we want. Probably we can accept the risk of Psalm's internals changing and breaking this. |
There was a problem hiding this comment.
@orklah how stable is this stuff? Just want to see if we need to pin to psalm at patch level, from now on 🤔
There was a problem hiding this comment.
I'm also happy to have a go at using one of the subclasses of https://github.com/vimeo/psalm/blob/5.x/src/Psalm/Report.php to avoid the InternalProperty access.
There was a problem hiding this comment.
Note: we pin to the patch version of infection/infection because we want to prevent inadverted BC breaks.
If we can avoid depending on @internal in Psalm, we could avoid having to do it for vimeo/psalm
There was a problem hiding this comment.
Honestly, Psalm's internals are not easily accessible. We added @internal mainly to have some support for BC breaks checks.
Psalm is not moving very fast currently so the risk of things breaking is low though
…c analysis
See #485