-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
484: Add warning about Psalm baseline to readme + functional test #489
Open
bdsl
wants to merge
11
commits into
Roave:1.35.x
Choose a base branch
from
bdsl:484-baseline-misleading-results
base: 1.35.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdsl
changed the title
484: Add warning about Psalm baseline to readme
484: Add warning about Psalm baseline to readme + functional test
Dec 2, 2023
Ocramius
reviewed
Dec 2, 2023
…m issues exist in baseline
Ocramius
force-pushed
the
484-baseline-misleading-results
branch
from
February 8, 2024 16:12
8e8dff8
to
ea6ce9c
Compare
Ocramius
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Feb 8, 2024
Ocramius
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This went totally under my radar - now rebased and merging ASAP
Ocramius
force-pushed
the
484-baseline-misleading-results
branch
from
February 8, 2024 16:49
8c06296
to
87842c8
Compare
Oooof, XDebug missing is a pain here, and blocks merge :S |
Very confused why this fails without any dependency checks, while the mainline build is fine Why would it be different, since |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #484