Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow php 8.3 #480

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Allow php 8.3 #480

merged 4 commits into from
Sep 15, 2023

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Sep 13, 2023

No description provided.

@fezfez fezfez mentioned this pull request Sep 13, 2023
Merged
@Ocramius Ocramius added the enhancement New feature or request label Sep 13, 2023
@Ocramius Ocramius added this to the 1.33.0 milestone Sep 13, 2023
@Ocramius
Copy link
Member

Ha, chicken-egg scenario.

Perhaps we can remove ocramius/package-versions and rely on the composer-runtime-api instead? I don't even remember where it is used :D

@fezfez
Copy link
Contributor Author

fezfez commented Sep 14, 2023

@Ocramius done, and i've moved the deps in require-dev

@Ocramius Ocramius self-assigned this Sep 14, 2023
@Ocramius
Copy link
Member

Seems like sources still use the other package? 🤔

@fezfez
Copy link
Contributor Author

fezfez commented Sep 14, 2023

Seems like sources still use the other package? 🤔

my bad it was in bin/ folder

@fezfez
Copy link
Contributor Author

fezfez commented Sep 15, 2023

ping !

Ocramius
Ocramius approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez!

@Ocramius Ocramius merged commit 3dd4ea3 into Roave:1.33.x Sep 15, 2023
12 checks passed
@Ocramius Ocramius changed the title allow php 8.3 Allow php 8.3 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fezfez @Ocramius