Removed redundant Reflection*#setAccessible() calls

These are no longer needed as per PHP 8.1 and newer.
Roave · Dec 22, 2022 · a6fca4c · a6fca4c
1 parent e2d00ab
commit a6fca4c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 8 deletions.
diff --git a/src/Roave/InfectionStaticAnalysis/Bootstrapper.php b/src/Roave/InfectionStaticAnalysis/Bootstrapper.php
@@ -25,8 +25,6 @@ public static function bootstrap(
             );
         };
 
-        /** @infection-ignore-all */
-        $reflectionOffsetSet->setAccessible(true);
         $reflectionOffsetSet->invokeArgs($container, [MutantExecutionResultFactory::class, $factory]);
 
         return $container;

diff --git a/src/Roave/InfectionStaticAnalysis/RunStaticAnalysisAgainstEscapedMutant.php b/src/Roave/InfectionStaticAnalysis/RunStaticAnalysisAgainstEscapedMutant.php
@@ -31,9 +31,6 @@ public function __construct(
     ) {
         $this->reflectionOriginalStartFileLocation = new ReflectionProperty(MutantExecutionResult::class, 'originalStartFilePosition');
         $this->reflectionOriginalEndFilePosition   = new ReflectionProperty(MutantExecutionResult::class, 'originalEndFilePosition');
-
-        $this->reflectionOriginalStartFileLocation->setAccessible(true);
-        $this->reflectionOriginalEndFilePosition->setAccessible(true);
     }
 
     public function createFromProcess(MutantProcess $mutantProcess): MutantExecutionResult

diff --git a/test/unit/Roave/InfectionStaticAnalysisTest/RunStaticAnalysisAgainstEscapedMutantTest.php b/test/unit/Roave/InfectionStaticAnalysisTest/RunStaticAnalysisAgainstEscapedMutantTest.php
@@ -142,9 +142,6 @@ public function testWillKillMutantsThatEscapedAndFailedStaticAnalysis(): void
         $reflectionOriginalStartFileLocation = new ReflectionProperty(MutantExecutionResult::class, 'originalStartFilePosition');
         $reflectionOriginalEndFilePosition   = new ReflectionProperty(MutantExecutionResult::class, 'originalEndFilePosition');
 
-        $reflectionOriginalStartFileLocation->setAccessible(true);
-        $reflectionOriginalEndFilePosition->setAccessible(true);
-
         self::assertSame(2, $reflectionOriginalStartFileLocation->getValue($nextFactoryResult));
         self::assertSame(8, $reflectionOriginalEndFilePosition->getValue($nextFactoryResult));
     }