Update plantuml JAR - Fix ability to use hexagon in plantuml diagrams #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Mar 17, 2022
Ocramius
reviewed
Mar 17, 2022
asgrim
force-pushed
the
fix-hexagon-in-plantuml
branch
from
5703c6f
to
dd071cb
Compare
Ocramius
approved these changes
Mar 17, 2022
| @grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' | ||
|
|
||
| build: ## Builds the development image needed to run tests etc. | ||
| docker buildx build --load --target=development --tag=test-image . |
There was a problem hiding this comment.
Didn't review in time :)
If this is in the makefile the tag should be something like roave/docbooktool:test-image; this current one resolves to test-image:latest which isn't scoped to a vendor/project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44