Implement ReflectionClass#getInterfaceClassNames()
#1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 7, 2023
Comment on lines
+429
to
+451
| public function testGetInterfaceNamesWithMissingInterfaceDefinitions(): void | ||
| { | ||
| $classInfo = (new DefaultReflector(new SingleFileSourceLocator( | ||
| __DIR__ . '/../Fixture/ClassWithMissingInterface.php', | ||
| $this->astLocator, | ||
| )))->reflectClass(ClassWithMissingInterface::class); | ||
|
|
||
| $this->expectException(IdentifierNotFound::class); | ||
|
|
||
| self::assertNotNull($classInfo->getInterfaceNames()); | ||
| } | ||
|
|
||
| public function testGetInterfacesWithMissingInterfaceDefinitions(): void | ||
| { | ||
| $classInfo = (new DefaultReflector(new SingleFileSourceLocator( | ||
| __DIR__ . '/../Fixture/ClassWithMissingInterface.php', | ||
| $this->astLocator, | ||
| )))->reflectClass(ClassWithMissingInterface::class); | ||
|
|
||
| $this->expectException(IdentifierNotFound::class); | ||
|
|
||
| self::assertNotNull($classInfo->getInterfaces()); | ||
| } |
There was a problem hiding this comment.
these tests show, that the pre-PR existing API always throws and therefore does not allow to get the interface names, when the class-symbols are not autoloadable.
staabm
commented
Aug 7, 2023
Comment on lines
+472
to
+476
| [ | ||
| __DIR__ . '/../Fixture/ClassWithMissingInterface.php', | ||
| ClassWithMissingInterface::class, | ||
| ['Roave\BetterReflectionTest\Fixture\InterfaceThatDoesNotExist'], | ||
| ], |
There was a problem hiding this comment.
this first test-case shows that we are now able to extract the interface names even if not autoloadable.
the remaining cases add coverage for a few more related cases like autoloadable classes, traits,..
|
This is a new feature: should go to |
Ocramius
approved these changes
Aug 7, 2023
|
oh sorry. did not relealize 6.12.x is already open |
|
Yeah, release automation does create a new branch each time :) |
|
Thanks @staabm! |
Ocramius
changed the title
Ocramius
changed the title
ReflectionClass#getInterfaceClassNames()
|
thank you. I am already working on the "trait-variant" of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same motivation as in #1359, but this time for interfaces :-)
refs rectorphp/rector#8093 (comment)
if we agree on this one, I should do another PR for
traitsas a followup