Infection: raise timeout for mutants from 10 to 60 seconds #1331
Conversation
|
The mutation score is really like some neverending zombie TV serie :) |
composer.json
Outdated
| "phpunit/phpunit": "10.0.5", | ||
| "phpstan/phpstan": "^1.9.17", | ||
| "phpstan/phpstan-phpunit": "^1.3.4", | ||
| "phpunit/phpunit": "^10.0.7", |
There was a problem hiding this comment.
If I follow your reasoning, this patch should be red also on the pre-existing PHPUnit version?
There was a problem hiding this comment.
Yep, even in the last PHPUnit 9.6.3 build you had more than a thousand mutants escaped under the timeout carpet:
https://github.com/Roave/BetterReflection/actions/runs/4092019766/jobs/7056471771#step:5:117
3676 mutations were generated:
2567 mutants were killed
0 mutants were configured to be ignored
0 mutants were not covered by tests
0 covered mutants were not detected
5 errors were encountered
0 syntax errors were encountered
3 time outs were encountered
1101 mutants required more time than configured
|
Github Actions is freaking slow, 60 seconds are not enough for another 392 mutants, while on my https://github.com/Roave/BetterReflection/actions/runs/4161271803/jobs/7199509066#step:5:116 I'll leave up to you to tweak it: if you raise it even higher you'll eventually get timed out mutants to zero, but the build could take almost 2 hours 🙄 |
|
@Slamdunk thanks for investigating this meanwhile! 💪 |
kukulich
force-pushed
the
infection_raise_timeout
branch
from
2ada1ff
to
8168896
Compare
The current 10 seconds timeout hides mutants that in reality are escaping if we raise it to just 60 seconds:
/cc @kukulich