Merge pull request #439 from lookyman/get-constructor-adapter-incompa…

…tibility Adapter's ReflectionClass::getConstructor() returns null when no constructor exists
Roave · Jul 31, 2018 · c022c6c · c022c6c
2 parents ca0298b + 69c9124
commit c022c6c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Reflection/Adapter/ReflectionClass.php b/src/Reflection/Adapter/ReflectionClass.php
@@ -4,6 +4,7 @@
 
 namespace Roave\BetterReflection\Reflection\Adapter;
 
+use OutOfBoundsException;
 use ReflectionClass as CoreReflectionClass;
 use ReflectionException as CoreReflectionException;
 use Roave\BetterReflection\Reflection\ReflectionClass as BetterReflectionClass;
@@ -127,7 +128,11 @@ public function getDocComment()
      */
     public function getConstructor()
     {
-        return new ReflectionMethod($this->betterReflectionClass->getConstructor());
+        try {
+            return new ReflectionMethod($this->betterReflectionClass->getConstructor());
+        } catch (OutOfBoundsException $e) {
+            return null;
+        }
     }
 
     /**

diff --git a/test/unit/Reflection/Adapter/ReflectionClassTest.php b/test/unit/Reflection/Adapter/ReflectionClassTest.php
@@ -4,6 +4,7 @@
 
 namespace Roave\BetterReflectionTest\Reflection\Adapter;
 
+use OutOfBoundsException;
 use PHPUnit\Framework\TestCase;
 use ReflectionClass as CoreReflectionClass;
 use ReflectionException as CoreReflectionException;
@@ -425,4 +426,16 @@ public function testGetExtensionNameReturnsFalseWhenNoExtensionName() : void
 
         self::assertFalse($reflectionClassAdapter->getExtensionName());
     }
+
+    public function testGetConstructorReturnsNullWhenNoConstructorExists() : void
+    {
+        $betterReflectionClass = $this->createMock(BetterReflectionClass::class);
+        $betterReflectionClass
+            ->method('getConstructor')
+            ->willThrowException(new OutOfBoundsException());
+
+        $reflectionClassAdapter = new ReflectionClassAdapter($betterReflectionClass);
+
+        self::assertNull($reflectionClassAdapter->getConstructor());
+    }
 }