Merge pull request #1386 from ondrejmirtes/fix-enum

CompileNodeToValue - allow getting enum constant
Roave · Jan 4, 2024 · 7f9bf2c · 7f9bf2c
2 parents 64af8fa + 59d82ca
commit 7f9bf2c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/NodeCompiler/CompileNodeToValue.php b/src/NodeCompiler/CompileNodeToValue.php
@@ -245,7 +245,9 @@ private function getClassConstantValue(Node\Expr\ClassConstFetch $node, string|n
         $classReflection = $classContext !== null && $classContext->getName() === $className ? $classContext : $context->getReflector()->reflectClass($className);
 
         if ($classReflection instanceof ReflectionEnum) {
-            throw Exception\UnableToCompileNode::becauseOfValueIsEnum($context, $classReflection, $node);
+            if ($classReflection->hasCase($constantName)) {
+                throw Exception\UnableToCompileNode::becauseOfValueIsEnum($context, $classReflection, $node);
+            }
         }
 
         $reflectionConstant = $classReflection->getConstant($constantName);

diff --git a/test/unit/NodeCompiler/CompileNodeToValueTest.php b/test/unit/NodeCompiler/CompileNodeToValueTest.php
@@ -764,6 +764,28 @@ class Bat {
         $classInfo->getConstant('ONE_VALUE')->getValue();
     }
 
+    public function testEnumConstantValueDoesNotThrowException(): void
+    {
+        $phpCode = <<<'PHP'
+        <?php
+
+        enum Foo: int {
+            const ONE = 1;
+        }
+        class Bat {
+            const ONE_VALUE = Foo::ONE;
+        }
+        PHP;
+
+        $reflector = new DefaultReflector(new AggregateSourceLocator([
+            new StringSourceLocator($phpCode, $this->astLocator),
+            new PhpInternalSourceLocator($this->astLocator, $this->sourceStubber),
+        ]));
+        $classInfo = $reflector->reflectClass('Bat');
+
+        self::assertSame(1, $classInfo->getConstant('ONE_VALUE')->getValue());
+    }
+
     /** @return list<array{0: string, 1: mixed}> */
     public static function magicConstantsWithoutNamespaceProvider(): array
     {