-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow img
and i
tags for sideBarMenuItem
#280
base: master
Are you sure you want to change the base?
Allow img
and i
tags for sideBarMenuItem
#280
Conversation
…SS in multiprogressbar
Thanks for your PR. My point here is that this PR brings many unrelated changes that are linked to other PR you made. I would advise to dedicate 1 new feature/fix per PR so that there is less risk to break things and to be easier to revert in case. |
@DivadNojnarg Doh, I didn't realize those branches were being added in when I merged them on my fork of the repo. I sent the Pull request before doing the merges, but I guess that does not preserve the PR in the form it is when the Pull request is made. How does one submit a PR to a remote repo, then merge it on their local fork, without having the PR pick up those changes? Or maybe I branched this from Both Pull Requests should introduce non-breaking changes FWIW |
tagAssert
now accepts multiple tag types totype