Skip to content

TypeScript generator: Use string type as the discriminator property type in specialized interfaces #261

TypeScript generator: Use string type as the discriminator property type in specialized interfaces

TypeScript generator: Use string type as the discriminator property type in specialized interfaces #261

Triggered via pull request July 17, 2024 13:41
Status Success
Total duration 7m 49s
Artifacts

pr.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

22 warnings
ubuntu-latest
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/RecordTests.cs(23,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Converters/JsonExceptionConverterTests.cs(26,23): warning CA1507: Use nameof in place of string literal 'CompanyKey' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/IgnoredPropertyTests.cs(15,27): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/IgnoredPropertyTests.cs(18,27): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/Generation/IgnoredPropertyTests.cs(39,27): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Tests/NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(21,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_schema_has_references_it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(38,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_external_schema_refs_they_are_resolved(string, string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(69,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_is__served_with_gzip_compression__it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(83,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_relative_external_schema_refs_in_subdirs__they_are_resolved(string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(115,24): warning CA1822: Member 'GetTestDirectory' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]