Add upstream exclusions to transitive dependencies #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's where clojure is installed for me on linux, and it seems like a pretty normal place that it could be.
Potential fix for RickMoynihan#66
|
Thanks for this and the comprehensive example, I'll try and find some time to review. |
|
@RickMoynihan did you have a chance to review this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #66.
It works by explicitly listing all
:exclusionsfrom a dep's parents in the dependency tree to ensure that leiningen doesn't add a dependency during its own dependency resolution that should have been excluded.I'll admit this is sort of inelegant so let me know if you have implementation opinions.