Move and Rename Static Mifare Classic Write Block Function #2626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/mifare/mifarehost.[c/h]
implementsmfReadBlock
andmfReadSector
so I was expecting to also findmfWriteBlock
andmfWriteSector
, but they don't exist. Looking a little further andcmdhfmf.c
used a staticfunction static bool mf_write_block
for this.As I want to use it in a hf gallagher extension I'd like it to not be static.
The other similar functions mentioned above return a PM3 status enum rather than bool's, so I also lightly refactored the uses of
mfWriteSector
to check forPM3_SUCCESS
or similar.I did read
However the other functions within
src/mifare/mifarehost.[c/h]
don't follow this convention, and I didn't want this to turn into a major refactor.