Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve cardhopper to improve reliability when parts of the packet are buffered #2607

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

nvx
Copy link
Contributor

@nvx nvx commented Nov 2, 2024

if packets arrive in quick succession part of the next packet can sit in the buffer which isn't checked by cardhopper resulting in the standalone hanging. this makes it check for data in the internal buffer too preventing that condition.

I expect the same benefit may occur in recieve_ng (sic) by changing the usb_poll_validate_length() check to be usb_read_ng_has_buffered_data() || usb_poll_validate_length() as this does in the cardhopper standalone but it'd need more testing. I've been testing this change with cardhopper for a few months now and I'm confident it's good but haven't tested the same change in recieve_ng yet

Copy link

github-actions bot commented Nov 2, 2024

You are welcome to add an entry to the CHANGELOG.md as well

@iceman1001 iceman1001 merged commit 60c2446 into RfidResearchGroup:master Nov 2, 2024
12 checks passed
@iceman1001
Copy link
Collaborator

Excellent!

@nvx nvx deleted the cardhopper_buffered branch November 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants