improve cardhopper to improve reliability when parts of the packet are buffered #2607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if packets arrive in quick succession part of the next packet can sit in the buffer which isn't checked by cardhopper resulting in the standalone hanging. this makes it check for data in the internal buffer too preventing that condition.
I expect the same benefit may occur in
recieve_ng
(sic) by changing theusb_poll_validate_length()
check to beusb_read_ng_has_buffered_data() || usb_poll_validate_length()
as this does in the cardhopper standalone but it'd need more testing. I've been testing this change with cardhopper for a few months now and I'm confident it's good but haven't tested the same change inrecieve_ng
yet