Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix photostudio's distance calculation formula #5759

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dligr
Copy link
Member

@dligr dligr commented Dec 17, 2024

Brief Description of What This PR Does

Fixes photostudio's formula for calculating the distance to the photographed object.

Additionally, changes a constant to compensate for the formula being changed; otherwise the distance calculated is slightly less than it should be.

The reasoning for the new formula:
image

Related Issues

A TODO in the code

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@dligr dligr added the review label Dec 17, 2024
@dligr dligr requested a review from a team December 17, 2024 15:24
@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.0 milestone Dec 18, 2024
@hhyyrylainen
Copy link
Member

I'm unsure about this change, especially this close to release. On one hand this makes many cells match the image size more closely, but caused many simple cells to have their images cutoff, which doesn't look good (also I checked the thriveopedia and this seems to help a bit there, I think).

So here's a screenshot with these changes:
2024-12-18_09 42 17 7422

And here's without (I'll note that most of the cutoff cells are no longer cutoff so this gives a better impression on how well the game is working):

2024-12-18_09 45 02 2099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants