This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Add an update.dataset() function #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SV and 2) check data existence before deletion
|
Note: this pull request implements the request in #75 |
|
@lixzhan Do you still plan to work on this submission? As it stands, I don't think the pull request is ready to include in the code base. It would be great if you could finish the work. |
|
I'm not certain where to improve to make it ready to be pulled. So please feel free to close this pull request and, if possible, write an update.dataset() function from your end. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update.dataset() function is a wrapper of delete.datasets() and upload.dataset(). Please double check the comments, which are based on those for upload.dataset().