Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply transform, multiple scenes support #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MikeTkachuk
Copy link
Contributor

Changes:

  • Quaternion data bug fix
  • Added section in apply transform to support GS, makes Join and Export Scene possible
image
  • fixes for my last PR to support multiple scenes

Thoughts:

  • might want to add apply transform to export operator logic by default
  • Apply rotation currently does not alter SH values, though i think it should

Would appreciate your testing/opinion, thanks!

@Wladefant
Copy link

@alexandre01 it seems as though you are not very active on github, so as not to create multiple different forks, I would suggest making @MikeTkachuk the collaborator, as he seems the most active and knowledgable right now.

@MikeTkachuk
Copy link
Contributor Author

That wouldn't hurt I guess, though I don't plan to add more features/maintain it much for now

@Wladefant
Copy link

haha alright, if you could test and review pull requests that would not be bad

@MikeTkachuk MikeTkachuk mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants