Updated asyncapi v2 typings to conform to JSON Schema draft-07 #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cd4c5ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jeremyfiel
force-pushed
the
refactor/asyncapi-types
branch
2 times, most recently
from
0c7d0b7
to
019ba1a
Compare
|
@jeremyfiel could you re-arrange the properties back just to see what's been changed? |
jeremyfiel
force-pushed
the
refactor/asyncapi-types
branch
from
019ba1a
to
ed4976b
Compare
tatomyr
reviewed
Jul 16, 2024
JLekawa
reviewed
Jul 16, 2024
JLekawa
approved these changes
Jul 16, 2024
jeremyfiel
force-pushed
the
refactor/asyncapi-types
branch
from
951f9fb
to
a87290e
Compare
jeremyfiel
force-pushed
the
refactor/asyncapi-types
branch
2 times, most recently
from
b02db39
to
8fe4023
Compare
tatomyr
reviewed
Jul 16, 2024
…hema draft-07 related Redocly#1219
jeremyfiel
force-pushed
the
refactor/asyncapi-types
branch
from
8fe4023
to
cd4c5ba
Compare
AlexVarchuk
approved these changes
Jul 17, 2024
tatomyr
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the v2 typings ONLY.
Per the specification, AsyncAPI v2 supports a superset of JSON Schema draft-07.
related Redocly/redoc#1219
What/Why/How?
The types defined in asyncapi.ts were copied from oas3_1 types but AsyncAPI does not support JSON Schema 2020-12, thus, many of the typings were invalid for proper validation and linting.
Reference
https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#schema-object
the list defined in their docs does not represent the terminology they have used. The list is copied from their earlier version specification documents and only minor updates were made. They indicate any JSON Schema core or validation keywords are supported from draft-07, so those updates were integrated here.
Testing
Screenshots (optional)
Check yourself
Security