Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Dockerfile to new version of pipenv #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reihl
Copy link
Member

@reihl reihl commented Jul 14, 2024

pipenv has been change and now you need to use pipenv requirements to create requirements.txt file

@reihl reihl force-pushed the fix_dockerfile_pipenv branch from 36cb9da to 71f707d Compare July 14, 2024 09:26
@sleviim
Copy link
Member

sleviim commented Jul 15, 2024

@nirs Hi Nir,
Can we merge this one?
Otherwise, students will need to run it manually

@nirs
Copy link
Member

nirs commented Jul 15, 2024

Getting rid of pipenv is better, but if this works it is an easier change. This project does not need pipenv locking. pip install with requirements.txt file is better and much faster.

@yaacov
Copy link
Member

yaacov commented Jul 17, 2024

Hi guys, we have a container friendly version in, no pipenv is used:
https://github.com/RedHat-Israel/rose-game-engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants