Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update soundtrack #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update soundtrack #422

wants to merge 1 commit into from

Conversation

benipeled
Copy link
Contributor

@sleviim as you wish 😉

sleviim
sleviim reviewed Dec 24, 2020
View reviewed changes
Copy link
Member

@sleviim sleviim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@rollandf, is this one OK from the respect of copyrights?

@sleviim sleviim requested a review from rollandf December 24, 2020 11:22
@rollandf
Copy link
Contributor

I don't think so...

LGTM.
@rollandf, is this one OK from the respect of copyrights?

I am not sure about it...

@sleviim
Copy link
Member

sleviim commented Dec 24, 2020

Is there maybe another soundtrack that can be added, from an open-source source?
maybe https://freesound.org/search/?q=drama?

@benipeled
Copy link
Contributor Author

I have nothing against the original soundtrack, it's all about the manual-soundtrack that has been in use for the last two years :)
I can't find useful information in a quick search so from my side we can close this PR unless someone wants to dig it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleviim sleviim sleviim left review comments

@rollandf rollandf Awaiting requested review from rollandf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benipeled @rollandf @sleviim