Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : mine page no task found issue #747

Merged
merged 11 commits into from
Jul 22, 2023
Merged

FIX : mine page no task found issue #747

merged 11 commits into from
Jul 22, 2023

Conversation

sahsisunny
Copy link
Member

@sahsisunny sahsisunny commented Jul 21, 2023

Closes: #748

Description of Changes:
This pull request aims to address the issue of tasks not being displayed on the mine page in our platform. The problem is likely due to a bug in the tasks API, and this PR includes the necessary changes to rectify the situation.

Changes Made:

  1. Updated Tasks API (RTK): The tasksAPI.ts file has been updated to ensure that it retrieves and provides the assigned tasks correctly to the mine page. The bug responsible for the missing tasks has been identified and fixed.
  2. Mine Page Updates: The mine page components have been modified to handle the response from the updated tasks API and display the assigned tasks properly. Users should now be able to see their tasks on the mine page without any issues.

Test Coverage:
To ensure the correctness and robustness of the changes made, relevant tests have been added to cover the following scenarios:

  1. tasksAPI.ts (RTK) Test: New test cases have been added to verify that the tasks API returns the correct tasks for a specific user.
    tasksApi test coverage
  2. Mine Page Test: The mine page component has been tested to ensure that it correctly renders tasks when there are assigned tasks and displays an appropriate message when no tasks are available for the user.
    image

Anything you would like to inform the reviewer about:

  • No

Dev Tested:

  • Yes

Images/video of the change:

mine-fix.mp4

Follow-up Issues (if any)

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2023 9:18am

@apurvkhare
Copy link

In the video when you click on mine, we briefly see 'not authorized, click to login'
Since you are already logged in that should not appear.
Is there a separate issue filed for it?
image

@sahsisunny
Copy link
Member Author

sahsisunny commented Jul 21, 2023

In the video when you click on mine, we briefly see 'not authorized, click to login' Since you are already logged in that should not appear. Is there a separate issue filed for it?

This issue is related to useAuthenticated custom hook and @kotesh-arya is working on it (issue ticket #746 )

@@ -30,7 +30,7 @@ const Content = () => {

if (isLoading) return <p>Loading...</p>;
if (error) return <p>Something went wrong! Please contact admin</p>;
if (tasks && tasks.tasks?.length)
if (tasks && tasks.length)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its work

Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahsisunny sahsisunny merged commit b691df3 into develop Jul 22, 2023
2 checks passed
@sahsisunny sahsisunny deleted the fix/mine-page branch July 22, 2023 17:27
@sahsisunny sahsisunny mentioned this pull request Jul 22, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mine Page Tasks Not Showing
5 participants