Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add task request button to task details page #730

Merged
merged 7 commits into from
Aug 5, 2023
Merged

feat: Add task request button to task details page #730

merged 7 commits into from
Aug 5, 2023

Conversation

TanishqSingla
Copy link
Contributor

@TanishqSingla TanishqSingla commented Jul 17, 2023 •
edited
Loading

Issue:

closes #729

Pointers for reviwer

This feature is currently under dev flag so the design is subject to change.

Screenshots

 

ShowScreenshot from 2023-07-24 06-18-07

Dev Tested:

  • Yes

@vercel
Copy link

vercel bot commented Jul 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 10:36pm

@TanishqSingla TanishqSingla force-pushed the feat/button-to-add-taskRequest branch from 2d5aec4 to c60fad2 Compare July 17, 2023 23:00
@TanishqSingla
Copy link
Contributor Author

TanishqSingla commented Jul 18, 2023 •
edited
Loading

Test Coverage:

File % Stmts % Branch % Funcs % Lines Uncovered Line #348
components/taskDetails 88.57 86.53 79.16 88.4
taskRequestApi.ts 100 100 100 100

kotesh-arya
kotesh-arya reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@kotesh-arya kotesh-arya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments 🙂

__tests__/Unit/Components/Tasks/TaskDetails.test.tsx Outdated Show resolved Hide resolved
src/components/taskDetails/index.tsx Outdated Show resolved Hide resolved
src/pages/tasks/[id].tsx Outdated Show resolved Hide resolved
kotesh-arya
kotesh-arya previously approved these changes Jul 18, 2023
View reviewed changes
@TanishqSingla TanishqSingla force-pushed the feat/button-to-add-taskRequest branch from 2d2505b to 5b87a78 Compare July 18, 2023 18:26
@TanishqSingla TanishqSingla deleted the feat/button-to-add-taskRequest branch July 23, 2023 09:57
@TanishqSingla TanishqSingla restored the feat/button-to-add-taskRequest branch July 23, 2023 09:58
@TanishqSingla TanishqSingla reopened this Jul 23, 2023
@TanishqSingla TanishqSingla force-pushed the feat/button-to-add-taskRequest branch from 5b87a78 to 20723ef Compare July 23, 2023 10:16
@TanishqSingla TanishqSingla force-pushed the feat/button-to-add-taskRequest branch from 20723ef to fc0d64c Compare July 24, 2023 00:41
shreya-mishra
shreya-mishra previously approved these changes Jul 25, 2023
View reviewed changes
Pratiyushkumar
Pratiyushkumar approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pratiyushkumar
Pratiyushkumar suggested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write tests for taskRequestApi.ts as well

@TanishqSingla
fix: Review comments
1e397ec 
Add test for api
sahsisunny
sahsisunny reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@sahsisunny sahsisunny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All add the test coverage for all changes you made with all details.

@TanishqSingla
Copy link
Contributor Author

TanishqSingla commented Jul 31, 2023 •
edited
Loading

All add the test coverage for all changes you made with all details.

Test coverage are mentioned here

#730 (comment)

Pratiyushkumar
Pratiyushkumar approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashchoudhary07 prakashchoudhary07 merged commit d2fd26e into develop Aug 5, 2023
2 checks passed
@prakashchoudhary07 prakashchoudhary07 deleted the feat/button-to-add-taskRequest branch August 5, 2023 16:06
@Pratiyushkumar Pratiyushkumar mentioned this pull request Aug 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahsisunny sahsisunny sahsisunny approved these changes

@Pratiyushkumar Pratiyushkumar Pratiyushkumar approved these changes

@shreya-mishra shreya-mishra shreya-mishra left review comments

@kotesh-arya kotesh-arya Awaiting requested review from kotesh-arya

@bharati-21 bharati-21 Awaiting requested review from bharati-21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a button for users to request for tasks in task details
7 participants
@TanishqSingla @bharati-21 @shreya-mishra @kotesh-arya @sahsisunny @Pratiyushkumar @prakashchoudhary07