UI/task details page #726
Closed
UI/task details page #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ankitbajpai65 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
vinit717
reviewed
Jul 18, 2023
|
Hey @vinit717, I made the above mentioned changes. You can now check the changes |
vinit717
requested changes
Jul 22, 2023
package.json
Outdated
| "build": "next build", | ||
| "start": "next start -p $PORT", | ||
| "test": "jest --coverage", | ||
| "test-watch": "jest --watch ", | ||
| "lint": "next lint", | ||
| "lint-fix": "eslint . --fix --ext js,jsx,ts,tsx", |
Comment on lines
+13
to
+18
| @media (max-width: 450px) { | ||
| .wrapper { | ||
| margin: 0 10px; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Put media query always at the bottom of the file
src/components/taskDetails/index.tsx
Outdated
| @@ -58,7 +58,7 @@ const TaskDetails: FC<Props> = ({ taskID }) => { | |||
|
|
|||
| const { data: userData, isUserAuthorized } = useUserData(); | |||
|
|
|||
| const [isEditing, setIsEditing] = useState<boolean>(false); | |||
| const [isEditing, setIsEditing] = useState<boolean>(true); | |||
|
Hey @vinit717, can you check again. Thanks |
vinit717
requested changes
Jul 25, 2023
There was a problem hiding this comment.
Why there is a need to change package json it is just a simple CSS change
Comment on lines
106
to
111
| @media (max-width: 970px) { | ||
| .navBar { | ||
| display: flex; | ||
| flex-direction: row; | ||
| flex-wrap: wrap; | ||
| position: relative; |
There was a problem hiding this comment.
Please place this media query at the bottom of the file
There was a problem hiding this comment.
It is at the bottom, please check
|
@vinit717, Please check again. Thanks. |
vinit717
reviewed
Jul 27, 2023
|
This pull request work is done in this #779. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed CSS of the task details page and made it responsive for mobile.
Issue
#685 (comment)
Images/video of the change:
website-status.mp4