AssignTask to rtk #699

WYGIN · 2023-07-09T08:21:44Z

Issue: #671

Description:

migrated AssignTask api from Axios to RTK & wrote Tests to check AssignTask RTK mutation

Anything you would like to inform the reviewer about:

Dev Tested:

Yes

Test Coverage

Yes

Images/video of the change:

AssignTaskToRTK.mp4

Follow-up Issues (if any)

not due to my changes but the task assigned is not getting invisible until the next page reload if i try to assign first task, but the last task in the list is getting invisible after i assigned it.

vercel · 2023-07-09T08:21:47Z

@WYGIN is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

…quard-website-status into assignTaskToRTK

sahsisunny · 2023-07-13T10:58:04Z

Please add the test coverage screenshot of the changes

sahsisunny · 2023-07-16T00:44:43Z

Add the test coverage report of your changes only @WYGIN

prakashchoudhary07 · 2023-07-16T04:00:50Z

.eslintrc.json

@@ -18,7 +18,7 @@
    "plugins": ["react", "@typescript-eslint"],
    "rules": {
        "linebreak-style": ["error", "unix"],
-        "quotes": ["error", "single"],
+        "quotes": ["error", "single", { "avoidEscape": true }],


Why are we adding this rule here?
We should follow one

if i doesn't add it to eslint, eslint is trying to escape character & prettier is trying to avoid escaping characters, resulting in git push failure when i try to push changes

In that case, we should fix the prettier and eslint configurations, rather than just adding some rule to make precommits pass

In that case, we should fix the prettier and eslint configurations, rather than just adding some rule to make precommits pass

i searched a lot to fix that issue but not found any solution for it, so i reverted my code to use defalut lint rules

if you face an issue that is not linked to your PR, please create a separate issue ticket and PR for it

sahsisunny · 2023-07-17T13:18:16Z

__mocks__/handlers/self.handler.ts

+	id: 'aTOG168A86JXY5wVosJx',
+	github_display_name: 'Mahima Khandelwal',
+	github_id: 'Maheima',
+	roles: {
+		member: true,
+		archived: false,
+		super_user: false,
+	},
+	last_name: 'Khandelwal',
+	username: 'mahima',
+	incompleteUserDetails: false,
+	profileStatus: 'BLOCKED',
+	picture: {
+		publicId: 'profile/aTOG168A86JXY5wVosJx/fj2c46kpmpy3gi8tl63s',
+		url: 'https://res.cloudinary.com/realdevsquad/image/upload/v1674639637/profile/aTOG168A86JXY5wVosJx/fj2c46kpmpy3gi8tl63s.jpg'
+	},
+	status: 'active',
+	first_name: 'Mahima',
+	profileURL: 'https://mahima-profile-service.onrender.com'


Please use dummy data for test

Where?

That data is not created by me i refactored it tor DRY them up but now i replaced my tests with duplicate data in path __ tests __/Unit/hooks/tasksApi.test.tsx so no more tests depending on that data in my tests, the file is renamed from a js file to ts file https://github.com/Real-Dev-Squad/website-status/pull/699/files#diff-6e68b838da6a1b199fcb4ef878d985dd3e29de628b6bbbcdaca7cf99de329d3e

…gnee

prakashchoudhary07 · 2023-07-18T11:00:35Z

__tests__/Unit/Components/availability-panel/drag-drop-context/index.test.tsx

+export const urlPattern =
+    /(https:\/\/www\.|http:\/\/www\.|https:\/\/|http:\/\/)?[a-zA-Z]{2,}(\.[a-zA-Z]{2,})(\.[a-zA-Z]{2,})?\/[a-zA-Z0-9]{2,}|((https:\/\/www\.|http:\/\/www\.|https:\/\/|http:\/\/)?[a-zA-Z]{2,}(\.[a-zA-Z]{2,})(\.[a-zA-Z]{2,})?)|(https:\/\/www\.|http:\/\/www\.|https:\/\/|http:\/\/)?[a-zA-Z0-9]{2,}\.[a-zA-Z0-9]{2,}\.[a-zA-Z0-9]{2,}(\.[a-zA-Z0-9]{2,})?/g;


What pattern are we matching here?

What pattern are we matching here?

i changed that pattern with a simple relative url pattern please check it

…relative urls only

bhtibrewal · 2023-07-19T15:41:25Z

__tests__/Unit/Components/availability-panel/drag-drop-context/index.test.tsx

+        expect(unAssignedTaskNodes).toHaveLength(10);
+        expect(unAssignedTaskNodes[0]).toBeVisible();
+        expect(unAssignedTaskNodes[6]).toBeVisible();
+        getByText('Akash Shukla');


didn't understand why is this written at the end.

didn't understand why is this written at the end.

That line is to test if the member is in document or not. It will throw an error if the member is not in document or if that same member is in document for more than one time, resulting in test failure AFAIK

I would also add toBeVisible in my next commit so that it assures that component is rendering member

bhtibrewal · 2023-07-19T16:17:35Z

src/app/services/tasksApi.ts


            transformResponse: (response: TasksResponseType) => {
                return {
-                    tasks: response.tasks?.sort(
+                    tasks: [...response.tasks].sort(


why made this change?

why made this change?

The previous code might mutate the response, so i created a new array and pass the required changes without mutating the response

bhtibrewal · 2023-07-19T16:27:48Z

src/constants/payload.js

+    message: 'Task cannot be assigned to users with active or OOO status',
+};
+
+export function taskAssigned(Id) {


If this is a constants file, it should have this function

bhtibrewal

good work on the tests, left few comments, please address them

prakashchoudhary07 · 2023-08-02T18:01:03Z

Tests are failing please look into it

WYGIN and others added 5 commits July 3, 2023 11:33

added assignTask RTK

a7d13bd

replaced assignTask call with RTK

6a23ab2

fixed errors with rtk

820f2a3

Merge branch 'Real-Dev-Squad:develop' into assignTaskToRTK

62a0210

modified tests

95aeb95

WYGIN changed the title ~~Assign task to rtk~~ AssignTask to rtk Jul 9, 2023

WYGIN and others added 2 commits July 11, 2023 16:26

added tests to DragDropContextWraper component

260ca5e

Merge branch 'Real-Dev-Squad:develop' into assignTaskToRTK

228625f

WYGIN marked this pull request as ready for review July 11, 2023 11:33

WYGIN added 2 commits July 11, 2023 17:08

renamed test name

3f9e248

Merge branch 'assignTaskToRTK' of https://github.com/WYGIN/real-dev-s…

4123e2b

…quard-website-status into assignTaskToRTK

WYGIN closed this Jul 15, 2023

WYGIN force-pushed the assignTaskToRTK branch 2 times, most recently from 4123e2b to bc04ca3 Compare July 15, 2023 10:42

WYGIN added 3 commits July 15, 2023 18:17

improved tests

667a696

improved tests

6c704e0

solved merge conflict

73ab104

WYGIN reopened this Jul 15, 2023

prakashchoudhary07 reviewed Jul 16, 2023

View reviewed changes

WYGIN requested a review from prakashchoudhary07 July 17, 2023 07:09

WYGIN closed this Jul 17, 2023

WYGIN force-pushed the assignTaskToRTK branch 2 times, most recently from 73ab104 to 4bd3552 Compare July 17, 2023 07:11

resolved merge conflict

de63d38

WYGIN reopened this Jul 17, 2023

sahsisunny reviewed Jul 17, 2023

View reviewed changes

feat: added code to invalidate rtk cache on a task assigned to a assi…

dc98596

…gnee

fix: replaced tests with dummy data

9ef336b

WYGIN requested a review from sahsisunny July 18, 2023 07:35

prakashchoudhary07 reviewed Jul 18, 2023

View reviewed changes

reverted back to default eslint rules & changed url pattern to match …

b8af4c1

…relative urls only

WYGIN requested a review from prakashchoudhary07 July 19, 2023 08:26

bhtibrewal reviewed Jul 19, 2023

View reviewed changes

WYGIN and others added 3 commits July 20, 2023 15:36

taskAssigned converted from Fn to const

c4839d7

resolve merge commits

5e74d39

Merge branch 'develop' into assignTaskToRTK

9e51022

WYGIN requested a review from bhtibrewal July 20, 2023 11:10

WYGIN and others added 3 commits July 28, 2023 20:12

changed regix

e7690b8

Merge branch 'develop' into assignTaskToRTK

97c88da

Merge branch 'develop' into assignTaskToRTK

24f2f0a

Merge branch 'develop' into assignTaskToRTK

403cc80

sahsisunny closed this Nov 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AssignTask to rtk #699

AssignTask to rtk #699

WYGIN commented Jul 9, 2023 •

edited

Loading

vercel bot commented Jul 9, 2023

sahsisunny commented Jul 13, 2023

sahsisunny commented Jul 16, 2023

prakashchoudhary07 Jul 16, 2023

WYGIN Jul 16, 2023

prakashchoudhary07 Jul 18, 2023 •

edited

Loading

WYGIN Jul 19, 2023

bhtibrewal Jul 19, 2023 •

edited

Loading

sahsisunny Jul 17, 2023

WYGIN Jul 18, 2023

sahsisunny Jul 18, 2023

WYGIN Jul 18, 2023 •

edited

Loading

prakashchoudhary07 Jul 18, 2023

WYGIN Jul 19, 2023 •

edited

Loading

bhtibrewal Jul 19, 2023

WYGIN Jul 19, 2023 •

edited

Loading

bhtibrewal Jul 19, 2023

WYGIN Jul 20, 2023

bhtibrewal Jul 19, 2023

bhtibrewal left a comment

prakashchoudhary07 commented Aug 2, 2023

		export const urlPattern =
		/(https:\/\/www\.\|http:\/\/www\.\|https:\/\/\|http:\/\/)?[a-zA-Z]{2,}(\.[a-zA-Z]{2,})(\.[a-zA-Z]{2,})?\/[a-zA-Z0-9]{2,}\|((https:\/\/www\.\|http:\/\/www\.\|https:\/\/\|http:\/\/)?[a-zA-Z]{2,}(\.[a-zA-Z]{2,})(\.[a-zA-Z]{2,})?)\|(https:\/\/www\.\|http:\/\/www\.\|https:\/\/\|http:\/\/)?[a-zA-Z0-9]{2,}\.[a-zA-Z0-9]{2,}\.[a-zA-Z0-9]{2,}(\.[a-zA-Z0-9]{2,})?/g;

AssignTask to rtk #699

AssignTask to rtk #699

Conversation

WYGIN commented Jul 9, 2023 • edited Loading

Issue: #671

Description:

Anything you would like to inform the reviewer about:

Dev Tested:

Test Coverage

Images/video of the change:

Follow-up Issues (if any)

vercel bot commented Jul 9, 2023

sahsisunny commented Jul 13, 2023

sahsisunny commented Jul 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prakashchoudhary07 Jul 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhtibrewal Jul 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WYGIN Jul 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WYGIN Jul 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WYGIN Jul 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhtibrewal left a comment

Choose a reason for hiding this comment

prakashchoudhary07 commented Aug 2, 2023

WYGIN commented Jul 9, 2023 •

edited

Loading

prakashchoudhary07 Jul 18, 2023 •

edited

Loading

bhtibrewal Jul 19, 2023 •

edited

Loading

WYGIN Jul 18, 2023 •

edited

Loading

WYGIN Jul 19, 2023 •

edited

Loading

WYGIN Jul 19, 2023 •

edited

Loading