Replace accordion view with tab view for task list #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samarpan1738 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
samarpan1738
force-pushed
the
task-list-tab-view
branch
2 times, most recently
from
c48f0bb
to
9539220
Compare
samarpan1738
force-pushed
the
task-list-tab-view
branch
from
9539220
to
206ed6e
Compare
samarpan1738
force-pushed
the
task-list-tab-view
branch
from
206ed6e
to
bf0cc0c
Compare
hjaintech
reviewed
Mar 26, 2023
Comment on lines
+120
to
+135
| {!!error && <p>{TASKS_FETCH_ERROR_MESSAGE}</p>} | ||
| {isLoading ? ( | ||
| <p>Loading...</p> | ||
| ) : ( | ||
| <> | ||
| {Object.keys(filteredTask).length > 0 | ||
| ? Object.keys(filteredTask).map((key) => ( | ||
| <Accordion open={(statusActiveList.includes(key))} title={key} key={key}> | ||
| <TaskList tasks={filteredTask[key]} isEditable={isEditable} updateCardContent={updateCardContent} hasLimit={key == IN_PROGRESS}/> | ||
| </Accordion> | ||
| )) | ||
| : !error && 'No Tasks Found'} | ||
| ? <div className={classNames.tasksContainer}> | ||
| <div className={classNames.tabsContainer}> | ||
| <Tabs tabs={Object.values(Tab) as Tab[]} onSelect={onSelect} activeTab={activeTab}/> | ||
| </div> | ||
| <div> | ||
| {filteredTask[activeTab] ? <TaskList tasks={filteredTask[activeTab]} isEditable={isEditable} updateCardContent={updateCardContent}/> | ||
| :<EmptyTaskListLabel/>} | ||
| </div> | ||
| </div> | ||
| : !error && <EmptyTaskListLabel/>} |
There was a problem hiding this comment.
The highlighted piece of code has multiple levels of ternary operators being used which is making this code hard to understand/debug. I'd suggest looking for ways to flatten it out OR move some parts of code into separate functions like below
const renderTabSection = () => (
<div className={classNames.tabsContainer}>
<Tabs
tabs={Object.values(Tab) as Tab[]}
onSelect={onSelect}
activeTab={activeTab}
/>
</div>
);
const renderTaskList = () => (
<div>
{filteredTask[activeTab] ? (
<TaskList
tasks={filteredTask[activeTab]}
isEditable={isEditable}
updateCardContent={updateCardContent}
/>
) : (
<EmptyTaskListLabel />
)}
</div>
);
.
.
.
<div className={classNames.tasksContainer}>
{renderTabSection()}
{renderTaskList()}
</div>
.
.
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432
Changes
Preview video
Screen.Recording.2023-03-14.at.12.57.59.AM.mov