Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter dropdown and change task card style in mine page #1264

Merged
merged 17 commits into from
Sep 27, 2024

Conversation

pankajjs
Copy link
Contributor

@pankajjs pankajjs commented Sep 19, 2024

Date: 19 Sep 2024

Developer Name: Pankaj Sha


Issue Ticket Number

Description

This pr adds a filter dropdown component, changes the style of task card and implements filter logic.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Working video
1.mp4

Test Coverage

Screenshot 1 Screenshot 2024-09-26 at 6 20 11 PM
Screenshot 2 Screenshot 2024-09-27 at 4 55 42 PM

Additional Notes

Copy link

vercel bot commented Sep 19, 2024

@pankajjs is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

@vinit717
Copy link
Member

Did you design doc got approved?

@Ayushsanjdev
Copy link
Contributor

  1. PR name doesn't make any sense.
  2. Screen recording doesn't play.
    @pankajjs

@pankajjs
Copy link
Contributor Author

Did you design doc got approved?

Not approved till now. But you asked me to do some changes. I did.

@pankajjs pankajjs changed the title Fix:mine page Improved mine page, add filter dropdown and changed task card. Sep 20, 2024
@pankajjs pankajjs closed this Sep 20, 2024
@pankajjs pankajjs reopened this Sep 20, 2024
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need FF here

@vinit717
Copy link
Member

Where is TDD PR?
as mentioned in the design doc you are following TDD right

@pankajjs pankajjs changed the title Improved mine page, add filter dropdown and changed task card. Add filter dropdown and change task card style in mine page Sep 22, 2024
@pankajjs
Copy link
Contributor Author

Where is TDD PR? as mentioned in the design doc you are following TDD right

I have followed TDD. However I was not aware that I have to raise pr for TDD first. This pr contains every changes.

display old ui component when feature flag is disabled
display new ui component when feature flag is enabled
@pankajjs
Copy link
Contributor Author

don't we need FF here

Added FF.

iamitprakash
iamitprakash previously approved these changes Sep 22, 2024
@vinit717
Copy link
Member

@pankajjs are we not using the same component for the task tab
as the UI and functionality are the same

@pankajjs
Copy link
Contributor Author

pankajjs commented Sep 22, 2024

@pankajjs are we not using the same component for the task tab as the UI and functionality are the same

  1. Tasks page uses this two components with its own filter logic inside a component named TasksContent as it receives data in chunks while scrolling.
Screenshot 2024-09-22 at 11 33 18 PM Screenshot 2024-09-22 at 11 33 32 PM
  1. In Mine page, we receive data at once. Therefore, we are using these two components with its own filter logic.
  2. I have made the functionality looks same even the logic is different because of its data fetching technique.

@vinit717
Copy link
Member

@pankajjs are we not using the same component for the task tab as the UI and functionality are the same

  1. Tasks page uses this two components with its own filter logic inside a component named TasksContent as it receives data in chunks while scrolling.

Screenshot 2024-09-22 at 11 33 18 PM Screenshot 2024-09-22 at 11 33 32 PM
2. In Mine page, we receive data at once. Therefore, we are using these two components with its own filter logic.
3. I have made the functionality looks same even the logic is different because of its data fetching technique.

But self API should be paginate then as by this we don't need to create another component for this we can reuse it
can you confirm this with @ankushdharkar

@pankajjs
Copy link
Contributor Author

pankajjs commented Sep 24, 2024

@vinit717 Even If we make self API paginated, we need another component to make the filter and search should work as same as Tasks page because the TaskContent is tightly coupled with the hook which returns the tasks list.

src/pages/mine/index.tsx Outdated Show resolved Hide resolved
@vinit717
Copy link
Member

@vinit717 Even If we make self API paginated, we need another component to make the filter and search should work as same as Tasks page because the TaskContent is tightly coupled with the hook which returns the tasks list.

But we need to make the component dumb so it get the data and show accordingly
for now we can merge your PR and If you want, make the backend API paginated and change the frontend logic accordingly

src/utils/getInputValueFromTaskField.ts Outdated Show resolved Hide resolved
src/pages/mine/index.tsx Show resolved Hide resolved
@pankajjs
Copy link
Contributor Author

pankajjs commented Sep 25, 2024

@vinit717 Even If we make self API paginated, we need another component to make the filter and search should work as same as Tasks page because the TaskContent is tightly coupled with the hook which returns the tasks list.

But we need to make the component dumb so it get the data and show accordingly for now we can merge your PR and If you want, make the backend API paginated and change the frontend logic accordingly

We can merge this Pr. For the backend, I will pick it in another task.

@vinit717 vinit717 merged commit 86c825a into Real-Dev-Squad:develop Sep 27, 2024
1 of 2 checks passed
@vinit717 vinit717 mentioned this pull request Sep 30, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix]: mine page
5 participants