-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter dropdown and change task card style in mine page #1264
Conversation
add filter dropdown component fix task card component add filter logic
@pankajjs is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
Did you design doc got approved? |
|
Not approved till now. But you asked me to do some changes. I did. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need FF here
Where is TDD PR? |
I have followed TDD. However I was not aware that I have to raise pr for TDD first. This pr contains every changes. |
display old ui component when feature flag is disabled display new ui component when feature flag is enabled
Added FF. |
@pankajjs are we not using the same component for the task tab |
|
But self API should be paginate then as by this we don't need to create another component for this we can reuse it |
@vinit717 Even If we make self API paginated, we need another component to make the filter and search should work as same as Tasks page because the TaskContent is tightly coupled with the hook which returns the tasks list. |
But we need to make the component dumb so it get the data and show accordingly |
We can merge this Pr. For the backend, I will pick it in another task. |
Date: 19 Sep 2024
Developer Name: Pankaj Sha
Issue Ticket Number
Description
This pr adds a filter dropdown component, changes the style of task card and implements filter logic.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Working video
1.mp4
Test Coverage
Screenshot 1
Screenshot 2
Additional Notes