Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update assign to username for status DONE #1015

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

shubhamsinghbundela
Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela commented Nov 21, 2023

Issue: #1017

Description:

  • Assign button not visible when task card status DONE.

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Images/video of the change:

Before change:

iQ3igUpiei.mp4

After change

ExjZgOCIi9.mp4

Test stats:

src/components/tasks/card/index.tsx
image

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 1:28pm

@@ -230,7 +230,7 @@ const Card: FC<CardProps> = ({
const hasIssueAssignee = () => cardDetails.github?.issue.assignee ?? false;
const hasTaskAssignee = () => cardDetails.assignee ?? false;
const isIssueClosed = () => cardDetails.github?.issue?.status === 'closed';
const isTaskComplete = () => cardDetails.status === COMPLETED;
const isTaskComplete = () => cardDetails.status === DONE;
Copy link
Member

@vinit717 vinit717 Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems to be uncovered as you provide this coverage

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants