generated from Real-Dev-Squad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update assign to username for status DONE #1015
Open
shubhamsinghbundela
wants to merge
4
commits into
develop
Choose a base branch
from
remove-feature-flag-03
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ajoykumardas12
approved these changes
Nov 22, 2023
vinit717
reviewed
Nov 22, 2023
@@ -230,7 +230,7 @@ const Card: FC<CardProps> = ({ | |||
const hasIssueAssignee = () => cardDetails.github?.issue.assignee ?? false; | |||
const hasTaskAssignee = () => cardDetails.assignee ?? false; | |||
const isIssueClosed = () => cardDetails.github?.issue?.status === 'closed'; | |||
const isTaskComplete = () => cardDetails.status === COMPLETED; | |||
const isTaskComplete = () => cardDetails.status === DONE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1017
Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Images/video of the change:
Before change:
iQ3igUpiei.mp4
After change
ExjZgOCIi9.mp4
Test stats:
src/components/tasks/card/index.tsx