Fix: Side panel data not updating when different user cards are clicked #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajjs
reviewed
Oct 24, 2024
vinit717
reviewed
Oct 26, 2024
|
Add the Screenshot of the test coverage that you added, not the success of all the test case |
pankajjs
reviewed
Oct 28, 2024
|
Add PR Description, of what changed |
pankajjs
approved these changes
Oct 28, 2024
vinit717
approved these changes
Oct 28, 2024
Merged
VaibhavSingh8
pushed a commit
that referenced
this pull request
Nov 4, 2024
…ed (#900) * Fix: Side panel data not updating when different user cards are clicked * renamed the variable * added tests * using staging api url for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 24 Oct 2024
Developer Name: Anuj Chhikara (anuj-chhikara-1)
Issue Ticket Number
Description
This PR resolves an issue where the side panel failed to update when selecting different user cards. Previously, the side panel always displayed data from the initially selected user, regardless of subsequent selections, leading to outdated information and impacting user navigation.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Change File Tests
Complete Tests
Additional Notes
To address the issue of production API calls during test runs, I have added the following conditional code in the utils module:
Why This Change?
Before this update, tests were unintentionally hitting the production API. By adding this code, we ensure that only the staging API is called when tests run on this file. This setup also allows for mock data to be returned conditionally as needed, making tests more reliable and isolated from live data.
We already using this code in other script also for reference attaching image
