Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discord group search for multiple words in same string #897

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: discord group search for multiple words in same string #897

wants to merge 1 commit into from

Conversation

ssxdev
Copy link
Contributor

@ssxdev ssxdev commented Oct 20, 2024

Date: 20-10-2024

Developer Name: Surendar Singh

Description

  • Modified the discord group search to support the prefix of multiple words in the same discord name.
  • Before It was only searching for the prefix of the whole string, Now it will support searching for prefixes of all the words in the same name.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Before fix

image

image

After fix

image

image

Test Coverage

Screenshot

image

yesyash
yesyash reviewed Oct 26, 2024
View reviewed changes
groups/utils.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • why is this change not under feature flag ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesyash yesyash yesyash requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ssxdev ssxdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssxdev @yesyash