Restrict approve and reject buttons on the Task Request detail page to super_user only #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnujChhikara
force-pushed
the
feature/restrict-approve-reject-buttons-to-super_users
branch
from
613f908
to
0609e65
Compare
yesyash
requested changes
Oct 21, 2024
vinit717
reviewed
Oct 21, 2024
I have added the test coverage screenshot |
vinit717
reviewed
Oct 24, 2024
vinit717
reviewed
Oct 24, 2024
removed unused variable
vinit717
reviewed
Oct 25, 2024
Achintya-Chatterjee
previously approved these changes
Oct 26, 2024
vinit717
reviewed
Oct 28, 2024
|
Please update the video also showing both for feature flag and behind feature flag |
vinit717
approved these changes
Oct 29, 2024
Achintya-Chatterjee
approved these changes
Oct 29, 2024
VaibhavSingh8
pushed a commit
that referenced
this pull request
Nov 4, 2024
…o super_user only (#896) * Restrict approve and reject buttons on the Task Request detail page to super users only * fixes naming convention, button render logic * fix: reject button should not be part of the dom if condition not met * changed the superUser data, make the task-request/script.js type module * added tests how buttons should render for non-super user * Update task-requestDetails.test.js removed unused variable * using data-testid for the tests * importing the superuser data * removing reject button from dom after successful task update * put the changes behind the feature flag --------- Co-authored-by: Achintya Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 19 Oct 2024
Developer Name: Anuj Chhikara (anuj-chhikara-1)
Issue Ticket Number
Description
super_userrole.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Updated Page
Buttons Working
Feature Flag
Test Coverage
Screenshot 1
Additional Notes