feat: UI for deleting discord groups by super users[dev = true] #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dashboard-rds with
|
| Latest commit: |
9cd3e2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a26f1d60.dashboard-rds.pages.dev |
| Branch Preview URL: | https://feat-delete-groups.dashboard-rds.pages.dev |
* made identity-service-logs page infinite scrollable * made identity-service-logs page infinite scrollable * made changes for feature flag --------- Co-authored-by: Amit Prakash <[email protected]>
* Display applied filters on applications page with clear option * Added test case and feature falg for filter
#856) * Display applied filters on applications page with clear option * Added test case and feature falg for filter * fixed the lazy loading bug due to filter
* added the infinite user loading feature * fixed the bugs in the loading * altered the API_BASE_URL to original one * added the infinite user loading feature * fixed the bugs in the loading * altered the API_BASE_URL to original one * updated the loader property * updated the test for the loading feature --------- Co-authored-by: Vinit khandal <[email protected]>
* New UI for profile update requests page * Error handeling * Handle API behind feature flag * Style changes * Refactor filenames * Refactored some code * Renamed * Refactored css and added css variables
This reverts commit d1726ed.
…ew button for application card (#853) * enhancement: added total count for selected status and removed the view button for application card * added tests * Update applications.test.js * fix: made changes to the test name * Update applications.test.js * Update index.html * Update utils.js * Update script.js * Update script.js * Update style.css * Update style.css * Update style.css * Update style.css * Update script.js * Update style.css * Update script.js
…ment-page (#860) * resolved the conflicts * fixed the user search feature bugs * refactored constants file * implemented the old changes * resolved the conflicts * fixed the user search feature bugs * refactored constants file * implemented the old changes * added the test fot the empty search after search once * fixed the repeating code --------- Co-authored-by: Yash Raj <[email protected]>
* shows index on pending applications * added data test-id to applications * removed logs
* changed port number from 5500 to 8000 * Disabled forced spaces for sublists * changed port number to 5500
changed tasks container details
* chore: fix test workflow file * chore: add comment for verify * chore: fix failing test
* enhancement: added shimmer effect * added e2e tests * removed comments from style.css * Update tests.yml This will be removed eventually * Update tests.yml * added uniform design to the card * fixed small error
* fix: Added footer contaning repo link for every webpage * fix: Added footer contaning repo link for every webpage * Enhancement: Added tests for new URLs * Enhancement: Added tests for new URLs * Fix: Removed Live URLs which do not have footer from testing * Enhancement: Fixed position for footer * fix: removed commented content * Enhancement: Used adata-test-id instead of class/id * Fix: footer position styling * Fix: changes using data-test-id * Fix: Prettier changes * Fix: minor bug fixes * Enhancement: Made reusable footer component * Enhancement: Replaced footer of webpages with footer component * Fix: Minor fixes * Fix: Removed additional footers * Fix: Removed additional footers * Fix: Removed additional footers * Fix: Added styles in global stylesheet * Fix: Minor fix of stylesheet * Fix: Test timeout error * Fix: Using data-test-id instead of classes --------- Co-authored-by: Vinit khandal <[email protected]>
* remove dev-ff from groups page * removed redundant code in search option of groups * chaging discord groups to prefix search
…ed (#900) * Fix: Side panel data not updating when different user cards are clicked * renamed the variable * added tests * using staging api url for testing
…o super_user only (#896) * Restrict approve and reject buttons on the Task Request detail page to super users only * fixes naming convention, button render logic * fix: reject button should not be part of the dom if condition not met * changed the superUser data, make the task-request/script.js type module * added tests how buttons should render for non-super user * Update task-requestDetails.test.js removed unused variable * using data-testid for the tests * importing the superuser data * removing reject button from dom after successful task update * put the changes behind the feature flag --------- Co-authored-by: Achintya Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 23 Sep 2024
Developer Name: Vaibhav Singh
Issue Ticket Number #819
Description
This PR introduces the ability for super users to delete discord groups. The feature is currently gated behind a development flag (dev). The following changes were made to implement this feature:
Changes:
createCard Function:
createDeleteConfirmationModal Function:
renderGroupById Function:
renderDeleteConfirmationModal Function:
removeDeleteConfirmationModal Function:
Helper Functions:
Rendering Logic:
Tests:
Notes:
The actual delete functionality is currently logged to the console and will be implemented in a future update.
The feature is only available when the dev flag is enabled.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes