Enabling Authentication and Authorization from a Single Middleware for Cookie and Bearer Token-Based Flows #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ashifkhn
approved these changes
Feb 27, 2024
Ajeyakrishna-k
previously approved these changes
Feb 27, 2024
Achintya-Chatterjee
previously approved these changes
Feb 27, 2024
Pavangbhat
commented
Feb 27, 2024
Pavangbhat
dismissed stale reviews from Achintya-Chatterjee and Ajeyakrishna-k
via
105f2d5
Pavangbhat
requested review from
Ajeyakrishna-k,
Achintya-Chatterjee and
ashifkhn
Achintya-Chatterjee
approved these changes
Feb 29, 2024
iamitprakash
requested changes
Mar 2, 2024
|
prakashchoudhary07
approved these changes
Mar 4, 2024
Achintya-Chatterjee
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 26-02-2024
Developer Name: Pavan Bhat
Issue Ticket Number
This ticket does not close the issue but solves a part of this issue
Description
Updated certain middlewares for specific routes, intended for migration to a cron job. This modification facilitates authentication and authorization through a unified middleware, accommodating both cookie-based authentication and authentication via public and private keys for APIs triggered within the cron job context.
Route's Modified:
User Status Update:
/users/status/updatePATCHIdle (No Auth & Auto):
/users/status?aggregate=trueGETBatch Idle:
/users/status/batchPATCHsyncExternalAccountsButton/external-accounts/users?action=discord-users-syncPOSTsyncUnverifiedUsersButton/users/POSTsyncIdleUsersButton/discord-actions/group-idlePUTsyncNickNamesButton/discord-actions/nicknames/sync?dev=truePOSTsyncIdle7dUsersButton/discord-actions/group-idle-7dPUTsyncOnboarding31dPlusUsersButton/discord-actions/group-onboarding-31d-plusPUTDocumentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Test cases for this new middleware is already present and current changes do not require any new test cases
Additional Notes
This approach still provides us capability of triggering these APIs through the dashboard site