Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: testing matcher and logging #7363

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

refactor: testing matcher and logging #7363

wants to merge 2 commits into from

Commits on Oct 27, 2023

  1. refactor: testing matcher and logging 

    Refactors the error matcher to accommodate the fact that we know the shape of the things we are testing. This is only a change to our own matchers and is not publicly exposed. This was tested by intentionally breaking several tests and checking outcomes. The debugginginformation provided by the assertion is also improved
    @benlesh
    benlesh committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    2913a4f View commit details
    Browse the repository at this point in the history

  2. chore: fix lint

    @benlesh
    benlesh committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    5bee7d2 View commit details
    Browse the repository at this point in the history