Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercise 19 switched Object.create() over to Object.assign() #132

Merged
merged 1 commit into from
Feb 5, 2016

Conversation

gabrielkunkel
Copy link
Contributor

Object.assign()

  • is more testable
  • more performant
  • functional (immutable data)
  • simpler to explain

(The education from improving on this was on par with the tutorial itself... Fantastic!)

NOTE: This is a new pull request with just the one commit. Sorry about that. :-)

closes #115 and #82

This was referenced Jan 28, 2016
@gabrielkunkel
Copy link
Contributor Author

Feel free to give me feedback. Let me know if there's anything wrong with this or if there's something I can do to improve it. :-)

@morenoh149
Copy link
Collaborator

Nothing, I usually try to get a second opinion as I don't have time to review changes. But here goes.

morenoh149 added a commit that referenced this pull request Feb 5, 2016
exercise 19 switched Object.create() over to Object.assign()
@morenoh149 morenoh149 merged commit f8d0a2c into ReactiveX:gh-pages Feb 5, 2016
@gabrielkunkel
Copy link
Contributor Author

Cool! This was fun! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why use Object.create in exercise 19?
2 participants