hot fix for forward diff issue 706

[bvdmitri]

This PR implements a small hot-fix for JuliaDiff/ForwardDiff.jl#706

[bvdmitri]

It's technically still broken, but covers at least the most common use case with Float64

[Nimrais]

Yeah, but we can just remove forwarddiff from the MLE.

[Nimrais]

I see no reason why the ForwardDiff is used there, and probably there should be a test for this change to fix

[bvdmitri]

Yeah, but we can just remove forwarddiff from the MLE.

You're right, but I would not say "just" in this context :D It's quite some work and ForwardDiff actually works pretty fast as for now, this hot-fix allows us to proceed further. We can drop the dependency on ForwardDiff later since its not as easy as this patch

[Nimrais]

ok

[bvdmitri]

But I'm up to removing ForwardDiff from MLE indeed, it would be much better

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (d9408e4) to head (81539de).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          24       24           
  Lines         323      323           
=======================================
  Hits          312      312           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bvdmitri]

I've added a test for this