This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
馃悙 Replace joins for loop with a .find array opt. #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of the for loop in this case was to find (if present) an entity in the joinObserveArray who's queue has no elements, when that element was found hasValues was set to false and the for loop was exited. The semantics of this code can be replaced with a more "idiomatic" find operation which will do the following: 1. loop over each element until an element is found 2. return the found element which can be used to set hasValues to false; --- Thanks so much for your time reviewing this PR and have a great day!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of the for loop in this case was to find (if present) an entity in the joinObserveArray who's queue has no elements, when that element was found hasValues was set to false and the for loop was exited.
The semantics of this code can be replaced with a more "idiomatic" find operation which will do the following:
Thanks so much for your time reviewing this PR and have a great day!