Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve the API URL in Settings #2033

Open
wants to merge 6 commits into
base: compose-dev
Choose a base branch
from
Open

feat: Improve the API URL in Settings #2033

wants to merge 6 commits into from

Conversation

validcube
Copy link
Member

@validcube validcube commented Jul 4, 2024 •
edited
Loading

image

@ https://canary.discord.com/channels/952946952348270622/952987428786941952/1258456626457739415

Note

This PR include three changes

  • Annotate @Preview for the API URL Dialog
  • Update style for API URL Dialog
  • Update description for API URL Settings

Fix

@validcube validcube requested a review from oSumAtrIX July 4, 2024 16:23
This was linked to issues Jul 4, 2024
bug: Odd usage of icon for API URL popup #1972
Closed
feat: Improve API URL setting dialog #1976
Open
@validcube validcube added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 4, 2024
@validcube validcube changed the title feat: Improve API URL Dialog in Settings feat: Improve the API URL dialog in Settings Jul 4, 2024
@Axelen123 Axelen123 linked an issue Jul 5, 2024 that may be closed by this pull request
bug: No proper description for API URL setting #1973
Open
4 tasks
@validcube
Copy link
Member Author

validcube commented Jul 5, 2024 •
edited
Loading

@Axelen123 Is #1973 related? The issue appears to suggest replacing the pref value to actual description in the Settings page for API URL listview's description.

I could tackle that here since it's (soon-to-be:tm:) related to this PR.

@Ushie
Copy link
Member

Ushie commented Jul 5, 2024

Sure, you can do it in this PR

@Axelen123
Copy link
Member

@Axelen123 Is #1973 related? The issue appears to suggest replacing the pref value to actual description in the Settings page for API URL listview's description.

Oh, it looks like you are right. You can unlink the issue or take it on in this PR

@validcube validcube marked this pull request as draft July 5, 2024 14:02
@validcube
Copy link
Member Author

Snapshot of a822c25

image

@validcube
Copy link
Member Author

validcube commented Jul 7, 2024 •
edited
Loading

Snapshot of 9fd8971

image

Snapshot of 2e04b3c

image

@validcube validcube requested a review from oSumAtrIX July 7, 2024 09:09
@validcube validcube marked this pull request as ready for review July 7, 2024 09:10
@validcube validcube changed the title feat: Improve the API URL dialog in Settings feat: Improve the API URL in Settings Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axelen123 Axelen123 Axelen123 left review comments

@oSumAtrIX oSumAtrIX Awaiting requested review from oSumAtrIX

Assignees
No one assigned
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Milestone
No milestone
4 participants
@validcube @Ushie @Axelen123 @oSumAtrIX