Review #9
Open
Review #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2020 10:26
osamaakb
suggested changes
Jul 1, 2020
hanan_shirin_qays/moivesapp/src/Components/DropdownCategories.js
Outdated
Show resolved
Hide resolved
hanan_shirin_qays/moivesapp/src/Components/DropdownCategories.js
Outdated
Show resolved
Hide resolved
| function Footer() { | ||
| return ( | ||
| <div className="main-footer"> | ||
| <small style={{ marginRight: "20px" }}>Developed by </small>- |
There was a problem hiding this comment.
don't use inline styles, and have it in external css file
There was a problem hiding this comment.
This one we removed it all but still we had used some inline styling along the project it is not worth it to make a class for it it is so specific for one component
| import DropdownCategories from "./DropdownCategories"; | ||
| import { constructUrl } from "./Api"; | ||
|
|
||
| export default function SearchBox(props) { |
There was a problem hiding this comment.
extract the props here too
| handleQuery={props.handleQuery} | ||
| handleMovies={props.handleMovies} | ||
| isLoading={props.isLoading} | ||
| setIsLoading={props.setIsLoading} |
There was a problem hiding this comment.
why are you passing this here?
|
really good job, like how you separated the concerns, can you please put the github pages URL here too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.