Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependency constrains #1147

Merged
merged 3 commits into from
Oct 29, 2024
Merged

update dependency constrains #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cc10ee
update dependency cosnstrains
vcidst Oct 28, 2024
cf7bc04
update grpc code
vcidst Oct 28, 2024
e26a47e
update only pydantic
vcidst Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,5 @@ tests/executor_test_packages

grpc-standalone-server-integration-test-results.xml
grpc-server-docker-integration-test-results.xml

.vscode/
4 changes: 1 addition & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,7 @@ generate-grpc: ## generate grpc code
--pyi_out=. \
proto/action_webhook.proto

check-generate-grpc-code-in-sync: generate-grpc
check-generate-grpc-code-in-sync: ## check if the generated code is in sync with the proto files
# this is a helper to check if the generated code is in sync with the proto files
check-generate-grpc-code-in-sync: generate-grpc ## check if the generated code is in sync with the proto files, it uses a helper to check if the generated code is in sync with the proto files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you validated if this is not breaking make help target? Comment should be displayed as description for the target.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radovanZRasa Yes

❯ make help
...
check-generate-grpc-code-in-sync check if the generated code is in sync with the proto files, it uses a helper to check if the generated code is in sync with the proto files
...

git diff --exit-code rasa_sdk/grpc_py | if [ "$$(wc -c)" -eq 0 ]; then echo "Generated code is in sync with proto files"; else echo "Generated code is not in sync with proto files"; exit 1; fi

GRPC_STANDALONE_SERVER_INTEGRATION_TEST_RESULTS_FILE = grpc-standalone-server-integration-test-results.xml
Expand Down
2 changes: 1 addition & 1 deletion poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ opentelemetry-exporter-otlp = "~1.16.0"
grpcio = "1.59.3"
protobuf = "4.25.3"
grpcio-tools = "1.56.2"
pydantic = "2.6.4"
pydantic = "^2.6.4"
grpcio-health-checking = "1.59.3"

[tool.poetry.dev-dependencies]
Expand Down
Loading