Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-1235: Enable triggering release-tagging workflow manually on-demand also #1142

Conversation

AsadHasan-Rasa
Copy link
Collaborator

@AsadHasan-Rasa AsadHasan-Rasa commented Aug 28, 2024

Proposed changes:
Enable triggering release-tagging workflow manually on-demand also, in case previous auto-run(s) had failed, and we want to re-run on existing prepared-release- branch.

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • N/A
  • updated the documentation in the rasaHQ/rasa
  • N/A
  • updated the changelog (please check changelog for instructions)
  • N/A
  • reformat files using ruff (please check Readme for instructions)
  • N/A

…nd also, in case previous auto-run(s) had failed
@AsadHasan-Rasa AsadHasan-Rasa requested a review from a team as a code owner August 28, 2024 17:04
@AsadHasan-Rasa AsadHasan-Rasa requested review from rasa-aadlv, sanchariGr and a team and removed request for a team and rasa-aadlv August 28, 2024 17:04
@sanchariGr
Copy link
Collaborator

@AsadHasan-Rasa can you also please remove env.IS_TAG_BUILD from The notify success and failure notifications here?

@AsadHasan-Rasa
Copy link
Collaborator Author

@AsadHasan-Rasa can you also please remove env.IS_TAG_BUILD from The notify success and failure notifications here?

Done. If ok, I've also removed env.IS_TAG_BUILD from the failure notification (https://github.com/RasaHQ/rasa-sdk/blob/main/.github/workflows/release-artifacts.yml#L157), because iiuc the same pattern applies there also, and we want to be consistent?

@AsadHasan-Rasa AsadHasan-Rasa enabled auto-merge (squash) August 29, 2024 08:36
@AsadHasan-Rasa AsadHasan-Rasa merged commit cc95cc1 into main Aug 29, 2024
14 of 15 checks passed
@AsadHasan-Rasa AsadHasan-Rasa deleted the ENG-1235-enable-triggering-tagging-workflow-manually-on-demand-also branch August 29, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants