Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build multi-platform docker images on release #1124

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Build multi-platform docker images on release #1124

merged 3 commits into from
Jul 10, 2024

Conversation

radovanZRasa
Copy link
Contributor

@radovanZRasa radovanZRasa commented Jul 9, 2024 •
edited
Loading

Rearrange build of Docker images in GitHub workflows for easier management:

  • Add new workflow to build image when code is merged to main
  • Build Docker dev image with pr### (ex. pr1234) tag on pull requests, devs should use this image if they need it in rasa
  • Move build of Docker images and PyPi package when tag is pushed to a new workflow
  • Add separate workflow to cleanup dev docker image created with pr### tag when pull request is merged. Devs who are working on rasa should switch to the latest image once PR on rasa-sdk is merged.

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@radovanZRasa radovanZRasa requested a review from a team as a code owner July 9, 2024 16:36
@radovanZRasa radovanZRasa requested review from rafaeljcdarce and removed request for a team July 9, 2024 16:36
@radovanZRasa radovanZRasa marked this pull request as draft July 9, 2024 16:36
@radovanZRasa radovanZRasa changed the base branch from main to 3.9.x July 9, 2024 22:13
@radovanZRasa radovanZRasa marked this pull request as ready for review July 9, 2024 22:14
@radovanZRasa
Copy link
Contributor Author

The check which is hanging should be replaced in the repo's settings but I would prefer we first do a code review before that is done.

sanchariGr
sanchariGr reviewed Jul 10, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
sanchariGr
sanchariGr requested changes Jul 10, 2024
View reviewed changes
.github/workflows/pr-cleanup.yml Show resolved Hide resolved
.github/workflows/pr-merged.yml Show resolved Hide resolved
.github/workflows/release-artifacts.yml Show resolved Hide resolved
sanchariGr
sanchariGr approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@sanchariGr sanchariGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@radovanZRasa
Add workflow_dispatch to release-artifacts GitHub workflow to allow m…
158a083 
…anual release of Docker images and PyPI packages
@radovanZRasa radovanZRasa merged commit 6b007e5 into 3.9.x Jul 10, 2024
14 checks passed
@radovanZRasa radovanZRasa deleted the ci/push-PR-dev-images branch July 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchariGr sanchariGr sanchariGr approved these changes

@rafaeljcdarce rafaeljcdarce Awaiting requested review from rafaeljcdarce rafaeljcdarce is a code owner automatically assigned from RasaHQ/infrastructure-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radovanZRasa @sanchariGr