Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change missing domain log level in rasa-sdk from ERROR to DEBUG #1113

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/1113.misc.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Changed log message level from `error` to `debug`.
- Rephrased the log message to precisely describe that the request is being retried if the domain context is missing.
- Referenced this behavior in the documentation.
2 changes: 1 addition & 1 deletion rasa_sdk/endpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ async def webhook(request: Request) -> HTTPResponse:
body = {"error": e.message, "action_name": e.action_name}
return response.json(body, status=404)
except ActionMissingDomainException as e:
logger.error(e)
logger.debug(e)
body = {"error": e.message, "action_name": e.action_name}
return response.json(body, status=449)

Expand Down
7 changes: 6 additions & 1 deletion rasa_sdk/interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,12 @@ class ActionMissingDomainException(Exception):

def __init__(self, action_name: Text, message: Optional[Text] = None) -> None:
self.action_name = action_name
self.message = message or "Domain context is missing."
self.message = (
message
or "Missing domain context, assistant will retry the request and include "
"the domain in the request payload. For more information please see "
"https://rasa.com/docs/rasa-pro/action-server/"
)

def __str__(self) -> Text:
return self.message
Loading