[ATO-1652] Add unit tests for GRPCActionServerWebhook #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radovanZRasa
force-pushed
the
tests/ATO-1652-add-grpc-unit-tests
branch
from
3698521
to
d99f6fe
Compare
ancalita
reviewed
Jun 24, 2024
There was a problem hiding this comment.
Looks great 💯 The only suggestion I have is to move some of the fixtures either in the same module as test_grpc_server, or in other cases even prepend them with expected_response etc and not have them as fixtures since they're not being reused, it was a bit difficult to understand the test constantly switching between the two files.
radovanZRasa
force-pushed
the
tests/ATO-1652-add-grpc-unit-tests
branch
from
d99f6fe
to
41513c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for GRPCActionServerWebhook
Status (please check what you already did):
black(please check Readme for instructions)