Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping, Sprint 48 #1008

Merged
merged 11 commits into from
Jul 19, 2023
Merged

Housekeeping, Sprint 48 #1008

merged 11 commits into from
Jul 19, 2023

Conversation

vcidst
Copy link
Contributor

@vcidst vcidst commented Jul 18, 2023

Proposed changes:

There are no changes needed in pyproject.toml for the following so I'll be closing these PRs after updating the poetry.lock file with poetry update ruamel-yaml typing-extensions requests,

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@vcidst vcidst enabled auto-merge (squash) July 18, 2023 11:53
@vcidst vcidst changed the title Bump ruff from 0.0.256 to 0.0.277 Housekeeping, Sprint 48 Jul 18, 2023
@vcidst vcidst requested review from a team and Tawakalt and removed request for a team July 18, 2023 11:54
@vcidst vcidst disabled auto-merge July 18, 2023 11:55
@vcidst
Copy link
Contributor Author

vcidst commented Jul 18, 2023

@ancalita As per your comment here, how should I test that updating prompt-toolkit doesn't break commands in rasa-oss?

@vcidst vcidst requested a review from ancalita July 18, 2023 12:21
@ancalita
Copy link
Member

@ancalita As per your comment here, how should I test that updating prompt-toolkit doesn't break commands in rasa-oss?

I think this needs to be tested on a rasa-oss branch where you pin rasa-sdk branch to this branch. Then you test rasa interactive. Let me try to dig around Slack to see if i can find more details beyond my faded memories 😆

@ancalita
Copy link
Member

@vcidst Managed to find this PR that describes that the prompt toolkit upgrade was breaking unit tests in rasa-oss (with a link to submitted ticket in prompt-toolkit repo). It seems that beyond testing rasa shell and rasa interactive we need to be careful CI passes on OSS end as well. Hope this helps!

@vcidst
Copy link
Contributor Author

vcidst commented Jul 19, 2023

@ancalita Thank you for the insight! I'll leave prompt-toolkit out of this housekeeping PR in that case and create a ticket to update it

https://rasahq.atlassian.net/browse/ATO-1303

@vcidst vcidst enabled auto-merge (squash) July 19, 2023 09:19
@vcidst vcidst merged commit ecbd0ad into main Jul 19, 2023
@vcidst vcidst deleted the hosuekeeping-48 branch July 19, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants