-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping, Sprint 48 #1008
Housekeeping, Sprint 48 #1008
Conversation
@ancalita As per your comment here, how should I test that updating prompt-toolkit doesn't break commands in rasa-oss? |
I think this needs to be tested on a rasa-oss branch where you pin rasa-sdk branch to this branch. Then you test |
@vcidst Managed to find this PR that describes that the prompt toolkit upgrade was breaking unit tests in rasa-oss (with a link to submitted ticket in prompt-toolkit repo). It seems that beyond testing |
@ancalita Thank you for the insight! I'll leave prompt-toolkit out of this housekeeping PR in that case and create a ticket to update it |
Proposed changes:
There are no changes needed in
pyproject.toml
for the following so I'll be closing these PRs after updating thepoetry.lock
file withpoetry update ruamel-yaml typing-extensions requests
,Status (please check what you already did):
black
(please check Readme for instructions)