Skip to content

Commit

Permalink
Simplify Artifact Handling and Upgrade to actions/*-artifact@v4
Browse files Browse the repository at this point in the history
- ZIP each emulator APK and upload once in batch rather than uploading each APK individually
- Upgrade actions/upload-artifact and actions/download-artifact from v3 to v4 for [performance and behavioral benefits](https://github.com/actions/download-artifact?tab=readme-ov-file#v4---whats-new)
  • Loading branch information
faf0 committed Feb 18, 2024
1 parent 0fd0c20 commit b920edc
Showing 1 changed file with 29 additions and 138 deletions.
167 changes: 29 additions & 138 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,7 @@ jobs:
- name: Copy 2600.emu artifact
if: ${{ matrix.image == '2600.emu' }}
run: |
cp 2600.emu/target/android-release/build/outputs/apk/release/2600Emu-release.apk EX-Emulators/2600Emu-release.apk
- name: Upload 2600.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == '2600.emu' }}
with:
name: 2600emu
path: ${{ github.workspace }}/2600.emu/target/android-release/build/outputs/apk/release/2600Emu-release.apk
cp 2600.emu/target/android-release/build/outputs/apk/release/2600Emu-release.apk EX-Emulators/2600Emu.apk
- name: Build C64.emu
if: ${{ matrix.image == 'C64.emu' }}
Expand All @@ -91,14 +84,7 @@ jobs:
- name: Copy C64.emu artifact
if: ${{ matrix.image == 'C64.emu' }}
run: |
cp C64.emu/target/android-release/build/outputs/apk/release/C64Emu-release.apk EX-Emulators/C64Emu-release.apk
- name: Upload C64.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'C64.emu' }}
with:
name: C64emu
path: ${{ github.workspace }}/C64.emu/target/android-release/build/outputs/apk/release/C64Emu-release.apk
cp C64.emu/target/android-release/build/outputs/apk/release/C64Emu-release.apk EX-Emulators/C64Emu.apk
- name: Build GBA.emu
if: ${{ matrix.image == 'GBA.emu' }}
Expand All @@ -109,14 +95,7 @@ jobs:
- name: Copy GBA.emu artifact
if: ${{ matrix.image == 'GBA.emu' }}
run: |
cp GBA.emu/target/android-release/build/outputs/apk/release/GbaEmu-release.apk EX-Emulators/GbaEmu-release.apk
- name: Upload GBA.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'GBA.emu' }}
with:
name: GBAemu
path: ${{ github.workspace }}/GBA.emu/target/android-release/build/outputs/apk/release/GbaEmu-release.apk
cp GBA.emu/target/android-release/build/outputs/apk/release/GbaEmu-release.apk EX-Emulators/GbaEmu.apk
- name: Build GBC.emu
if: ${{ matrix.image == 'GBC.emu' }}
Expand All @@ -127,14 +106,7 @@ jobs:
- name: Copy GBC.emu artifact
if: ${{ matrix.image == 'GBC.emu' }}
run: |
cp GBC.emu/target/android-release/build/outputs/apk/release/GbcEmu-release.apk EX-Emulators/GbcEmu-release.apk
- name: Upload GBC.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'GBC.emu' }}
with:
name: GBCemu
path: ${{ github.workspace }}/GBC.emu/target/android-release/build/outputs/apk/release/GbcEmu-release.apk
cp GBC.emu/target/android-release/build/outputs/apk/release/GbcEmu-release.apk EX-Emulators/GbcEmu.apk
- name: Build Lynx.emu
if: ${{ matrix.image == 'Lynx.emu' }}
Expand All @@ -145,14 +117,7 @@ jobs:
- name: Copy Lynx.emu artifact
if: ${{ matrix.image == 'Lynx.emu' }}
run: |
cp Lynx.emu/target/android-release/build/outputs/apk/release/LynxEmu-release.apk EX-Emulators/LynxEmu-release.apk
- name: Upload Lynx.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'Lynx.emu' }}
with:
name: Lynxemu
path: ${{ github.workspace }}/Lynx.emu/target/android-release/build/outputs/apk/release/LynxEmu-release.apk
cp Lynx.emu/target/android-release/build/outputs/apk/release/LynxEmu-release.apk EX-Emulators/LynxEmu.apk
- name: Build MD.emu
if: ${{ matrix.image == 'MD.emu' }}
Expand All @@ -163,14 +128,7 @@ jobs:
- name: Copy MD.emu artifact
if: ${{ matrix.image == 'MD.emu' }}
run: |
cp MD.emu/target/android-release/build/outputs/apk/release/MdEmu-release.apk EX-Emulators/MdEmu-release.apk
- name: Upload MD.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'MD.emu' }}
with:
name: MDemu
path: ${{ github.workspace }}/MD.emu/target/android-release/build/outputs/apk/release/MdEmu-release.apk
cp MD.emu/target/android-release/build/outputs/apk/release/MdEmu-release.apk EX-Emulators/MdEmu.apk
- name: Build MSX.emu
if: ${{ matrix.image == 'MSX.emu' }}
Expand All @@ -181,14 +139,7 @@ jobs:
- name: Copy MSX.emu artifact
if: ${{ matrix.image == 'MSX.emu' }}
run: |
cp MSX.emu/target/android-release/build/outputs/apk/release/MsxEmu-release.apk EX-Emulators/MsxEmu-release.apk
- name: Upload MSX.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'MSX.emu' }}
with:
name: MSXemu
path: ${{ github.workspace }}/MSX.emu/target/android-release/build/outputs/apk/release/MsxEmu-release.apk
cp MSX.emu/target/android-release/build/outputs/apk/release/MsxEmu-release.apk EX-Emulators/MsxEmu.apk
- name: Build NEO.emu
if: ${{ matrix.image == 'NEO.emu' }}
Expand All @@ -199,14 +150,7 @@ jobs:
- name: Copy NEO.emu artifact
if: ${{ matrix.image == 'NEO.emu' }}
run: |
cp NEO.emu/target/android-release/build/outputs/apk/release/NeoEmu-release.apk EX-Emulators/NeoEmu-release.apk
- name: Upload NEO.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'NEO.emu' }}
with:
name: NEOemu
path: ${{ github.workspace }}/NEO.emu/target/android-release/build/outputs/apk/release/NeoEmu-release.apk
cp NEO.emu/target/android-release/build/outputs/apk/release/NeoEmu-release.apk EX-Emulators/NeoEmu.apk
- name: Build NES.emu
if: ${{ matrix.image == 'NES.emu' }}
Expand All @@ -217,14 +161,7 @@ jobs:
- name: Copy NES.emu artifact
if: ${{ matrix.image == 'NES.emu' }}
run: |
cp NES.emu/target/android-release/build/outputs/apk/release/NesEmu-release.apk EX-Emulators/NesEmu-release.apk
- name: Upload NES.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'NES.emu' }}
with:
name: NESemu
path: ${{ github.workspace }}/NES.emu/target/android-release/build/outputs/apk/release/NesEmu-release.apk
cp NES.emu/target/android-release/build/outputs/apk/release/NesEmu-release.apk EX-Emulators/NesEmu.apk
- name: Build NGP.emu
if: ${{ matrix.image == 'NGP.emu' }}
Expand All @@ -235,14 +172,7 @@ jobs:
- name: Copy NGP.emu artifact
if: ${{ matrix.image == 'NGP.emu' }}
run: |
cp NGP.emu/target/android-release/build/outputs/apk/release/NgpEmu-release.apk EX-Emulators/NgpEmu-release.apk
- name: Upload NGP.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'NGP.emu' }}
with:
name: NGPemu
path: ${{ github.workspace }}/NGP.emu/target/android-release/build/outputs/apk/release/NgpEmu-release.apk
cp NGP.emu/target/android-release/build/outputs/apk/release/NgpEmu-release.apk EX-Emulators/NgpEmu.apk
- name: Build PCE.emu
if: ${{ matrix.image == 'PCE.emu' }}
Expand All @@ -253,14 +183,7 @@ jobs:
- name: Copy PCE.emu artifact
if: ${{ matrix.image == 'PCE.emu' }}
run: |
cp PCE.emu/target/android-release/build/outputs/apk/release/PceEmu-release.apk EX-Emulators/PceEmu-release.apk
- name: Upload PCE.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'PCE.emu' }}
with:
name: PCEemu
path: ${{ github.workspace }}/PCE.emu/target/android-release/build/outputs/apk/release/PceEmu-release.apk
cp PCE.emu/target/android-release/build/outputs/apk/release/PceEmu-release.apk EX-Emulators/PceEmu.apk
- name: Build Snes9x
if: ${{ matrix.image == 'Snes9x' }}
Expand All @@ -271,14 +194,7 @@ jobs:
- name: Copy Snes9x artifact
if: ${{ matrix.image == 'Snes9x' }}
run: |
cp Snes9x/target/android-release/build/outputs/apk/release/Snes9xEXPlus-release.apk EX-Emulators/Snes9xEXPlus-release.apk
- name: Upload Snes9x artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'Snes9x' }}
with:
name: Snes9x
path: ${{ github.workspace }}/Snes9x/target/android-release/build/outputs/apk/release/Snes9xEXPlus-release.apk
cp Snes9x/target/android-release/build/outputs/apk/release/Snes9xEXPlus-release.apk EX-Emulators/Snes9xEXPlus.apk
- name: Build Snes9x-1.43-9
if: ${{ matrix.image == 'Snes9x-1.43-9' }}
Expand All @@ -289,14 +205,7 @@ jobs:
- name: Copy Snes9x-1.43-9 artifact
if: ${{ matrix.image == 'Snes9x-1.43-9' }}
run: |
cp Snes9x/1.43/target/android-release-9/build/outputs/apk/release/Snes9xEX-release.apk EX-Emulators/Snes9xEX-9-release.apk
- name: Upload Snes9x-1.43-9 artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'Snes9x-1.43-9' }}
with:
name: Snes9x-1.43-9
path: ${{ github.workspace }}/Snes9x/1.43/target/android-release-9/build/outputs/apk/release/Snes9xEX-release.apk
cp Snes9x/1.43/target/android-release-9/build/outputs/apk/release/Snes9xEX-release.apk EX-Emulators/Snes9xEX-9.apk
- name: Build Snes9x-1.43-15
if: ${{ matrix.image == 'Snes9x-1.43-15' }}
Expand All @@ -307,14 +216,7 @@ jobs:
- name: Copy Snes9x-1.43-15 artifact
if: ${{ matrix.image == 'Snes9x-1.43-15' }}
run: |
cp Snes9x/1.43/target/android-release-15/build/outputs/apk/release/Snes9xEX-release.apk EX-Emulators/Snes9xEX-15-release.apk
- name: Upload Snes9x-1.43-15 artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'Snes9x-1.43-15' }}
with:
name: Snes9x-1.43-15
path: ${{ github.workspace }}/Snes9x/1.43/target/android-release-15/build/outputs/apk/release/Snes9xEX-release.apk
cp Snes9x/1.43/target/android-release-15/build/outputs/apk/release/Snes9xEX-release.apk EX-Emulators/Snes9xEX-15.apk
- name: Build Swan.emu
if: ${{ matrix.image == 'Swan.emu' }}
Expand All @@ -325,14 +227,7 @@ jobs:
- name: Copy Swan.emu artifact
if: ${{ matrix.image == 'Swan.emu' }}
run: |
cp Swan.emu/target/android-release/build/outputs/apk/release/SwanEmu-release.apk EX-Emulators/SwanEmu-release.apk
- name: Upload Swan.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'Swan.emu' }}
with:
name: Swanemu
path: ${{ github.workspace }}/Swan.emu/target/android-release/build/outputs/apk/release/SwanEmu-release.apk
cp Swan.emu/target/android-release/build/outputs/apk/release/SwanEmu-release.apk EX-Emulators/SwanEmu.apk
- name: Build Saturn.emu
if: ${{ matrix.image == 'Saturn.emu' }}
Expand All @@ -343,19 +238,12 @@ jobs:
- name: Copy Saturn.emu artifact
if: ${{ matrix.image == 'Saturn.emu' }}
run: |
cp Saturn.emu/target/android-release/build/outputs/apk/release/SaturnEmu-release.apk EX-Emulators/SaturnEmu-release.apk
- name: Upload Saturn.emu artifact
uses: actions/upload-artifact@v3
if: ${{ matrix.image == 'Saturn.emu' }}
with:
name: Saturnemu
path: ${{ github.workspace }}/Saturn.emu/target/android-release/build/outputs/apk/release/SaturnEmu-release.apk
cp Saturn.emu/target/android-release/build/outputs/apk/release/SaturnEmu-release.apk EX-Emulators/SaturnEmu.apk
- name: Upload EX-Emulators artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: EX-Emulators
name: EX-Emulators-${{ matrix.image }}
path: EX-Emulators/

release:
Expand All @@ -371,20 +259,23 @@ jobs:
fetch-depth: 0

- name: Download Artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: dist
path: EX-Emulators
pattern: EX-Emulators-*
merge-multiple: true

- name: Re-zip artifacts
run: |
cd dist
for artifact in *
mkdir dist
cd EX-Emulators || exit 1
for artifact in *.apk
do
echo "-> Creating ${artifact}.zip"
pushd "$artifact"
zip -r "../${artifact}.zip" *
popd
emulator_name="${artifact%.apk}"
echo "-> Creating ${emulator_name}.zip"
zip "../dist/${emulator_name}.zip" "${emulator_name}.apk"
done
zip -r ../dist/EX-Emulators.zip *.apk
- name: Update Git Tag
run: |
Expand Down

0 comments on commit b920edc

Please sign in to comment.