Api prog and meeting part 2 #194
Conversation
… tables during api user and wish calls
|
No problem, the programming language and meeting interval are found in the relational diagram #12 . Before this update when you viewed a user and their wishes the programming language id and the meeting interval id would appear instead of the value it related to. |
|
Added new api_user attribute 'username'. Set both 'email' and 'username' as unique attributes. Updated tests. These changes address issue #195 . I have not done anything with passwords, which is also mentioned in #195, as authentication has not been dealt with yet. I will mark issue #195 as done and create a new issue for passwords using text from issue #195 'Password is not visible in plain text (user doesn't see the characters they type)' |
There was a problem hiding this comment.
Good work. There is a bunch of comments - some not related to you change directly, but while reading the code, I found them and would just let you know. You can ignore them, if its too much.
But I am impressed to see the amount of work and how many part of the framework that are in play. It's really promising :)
| end | ||
|
|
||
| # context 'when email already in use' do | ||
| # let(:api_users.first |
There was a problem hiding this comment.
Did you mean to leave these here?
There was a problem hiding this comment.
These have been removed
Linked programming language and meeting interval information to api calls to api_user and wish.
Call only queries linked tables once to avoid multiple queries.
Filter now exists for true/false attributes on api_user and wish.
No tests have been written, no filters for string attributes.